fix unit-test

Author: pooknull

percona/controller/pgcluster/controller.go

@@ -334,6 +334,12 @@ func (r *PGClusterReconciler) reconcilePatroniVersionCheck(ctx context.Context,
 		cr.Annotations = make(map[string]string)
 	}
 
+	// This annotation is used for unit-tests only. Allows to skip the patroni version check
+	if _, ok := cr.Annotations[pNaming.InternalAnnotationDisablePatroniVersionCheck]; ok {
+		cr.Annotations[pNaming.AnnotationPatroniVersion] = cr.Status.PatroniVersion
+		return nil
+	}
+
 	getImageIDFromPod := func(pod *corev1.Pod, containerName string) string {
 		idx := slices.IndexFunc(pod.Status.ContainerStatuses, func(s corev1.ContainerStatus) bool {
 			return s.Name == containerName

percona/controller/pgcluster/controller_test.go

@@ -113,7 +113,6 @@ var _ = Describe("Annotations", Ordered, func() {
 	})
 
 	It("should create PerconaPGCluster with annotations", func() {
-		cr.Annotations = make(map[string]string)
 		cr.Annotations["pgv2.percona.com/trigger-switchover"] = "true"
 		cr.Annotations["egedemo.com/test"] = "true"
 

percona/controller/pgcluster/testutils_test.go

@@ -21,6 +21,7 @@ import (
 	"github.com/percona/percona-postgresql-operator/internal/controller/postgrescluster"
 	"github.com/percona/percona-postgresql-operator/internal/naming"
 	"github.com/percona/percona-postgresql-operator/percona/controller/pgbackup"
+	pNaming "github.com/percona/percona-postgresql-operator/percona/naming"
 	"github.com/percona/percona-postgresql-operator/percona/utils/registry"
 	"github.com/percona/percona-postgresql-operator/percona/watcher"
 	v2 "github.com/percona/percona-postgresql-operator/pkg/apis/pgv2.percona.com/v2"
@@ -94,6 +95,10 @@ func readTestCR(name, namespace, testFile string) (*v2.PerconaPGCluster, error)
 	if cr.Spec.PostgresVersion == 0 {
 		return nil, errors.New("postgresVersion should be specified")
 	}
+	if cr.Annotations == nil {
+		cr.Annotations = make(map[string]string)
+	}
+	cr.Annotations[pNaming.InternalAnnotationDisablePatroniVersionCheck] = "true"
 	cr.Status.Postgres.Version = cr.Spec.PostgresVersion
 	cr.Status.PatroniVersion = "4.0.0"
 	return cr, nil
@@ -112,6 +117,10 @@ func readDefaultCR(name, namespace string) (*v2.PerconaPGCluster, error) {
 	}
 
 	cr.Name = name
+	if cr.Annotations == nil {
+		cr.Annotations = make(map[string]string)
+	}
+	cr.Annotations[pNaming.InternalAnnotationDisablePatroniVersionCheck] = "true"
 	cr.Namespace = namespace
 	cr.Status.Postgres.Version = cr.Spec.PostgresVersion
 	cr.Status.PatroniVersion = "4.0.0"

percona/naming/annotations.go

@@ -39,4 +39,7 @@ const (
 	AnnotationClusterBootstrapRestore = PrefixPerconaPGV2 + "cluster-bootstrap-restore"
 
 	AnnotationPatroniVersion = PrefixPerconaPGV2 + "patroni-version"
+
+	// Should be used only for unit-testing
+	InternalAnnotationDisablePatroniVersionCheck = PrefixPerconaInternal + "patroni-version-check-disable"
 )