Skip to content

Commit 5d157e4

Browse files
haargkhwilliamson
authored andcommitted
rename select method to set_heading_select to avoid conflicts
Pod::Usage subclasses Pod::Simple and implements its own select method. That method tries to implement its own behavior but if a select method exists in the parent it will call that instead. This is for compatibility with inheriting from Pod::Parser instead. Avoid that compatibility issue by renaming the select method. It has only been available in a stable release for a few days and isn't yet documented, so it's pretty unlikely anyone is using it yet.
1 parent be06322 commit 5d157e4

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/Pod/Simple/BlackBox.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ sub _filter_allows {
703703
return 0;
704704
}
705705

706-
sub select {
706+
sub set_heading_select {
707707
my $self = shift;
708708
my (@selections) = @_;
709709

t/filter-html.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sub convert {
1212
$parser->html_header('');
1313
$parser->html_footer('');
1414
$parser->output_string(\$out);
15-
$parser->select(@$select);
15+
$parser->set_heading_select(@$select);
1616

1717
$parser->parse_string_document($pod);
1818
return $out;

t/filter.t

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ sub convert {
99
my $out = '';
1010
my $parser = Pod::Simple::JustPod->new;
1111
$parser->output_string(\$out);
12-
$parser->select(@$select);
12+
$parser->set_heading_select(@$select);
1313

1414
$parser->parse_string_document($pod);
1515
return $out;

0 commit comments

Comments
 (0)