Make clickable table rows use real hyperlinks

Keeps the existing functionality, but makes the site usable without JS and more
accessible with it (middle click etc.)

Author: Anthony Parsons

js/cpandatesters.js

@@ -1,9 +1,10 @@
 jQuery(document).ready(function($) {
     $(".clickableRow").click(function() {
-        if ($(this).attr("href"))
-            window.document.location = $(this).attr("href");
-        else if ($(this).attr("data-toggle")) {
-            var elem = $($(this).attr("data-toggle"));
+        var queryAttr;
+        if (queryAttr = $(this).find("a").attr("href"))
+            window.document.location = queryAttr;
+        else if (queryAttr = $(this).attr("data-toggle")) {
+            var elem = $(queryAttr);
             if(elem.hasClass("out")) {
                 elem.fadeIn();
                 elem.removeClass("out");

views/dist-line.tt

@@ -1,5 +1,5 @@
 % my ($x, $q, $url)  = @_;
-<tr class="clickableRow" href="/<%= $url %>">
+<tr class="clickableRow">
     <td>
         <div class="progress progress-top" title="MoarVM">
             <div class="progress-bar progress-bar-success" style="width: <%= $q<moar><pass> %>%"></div>
@@ -12,7 +12,7 @@
             <div class="progress-bar progress-bar-danger"  style="width: <%= $q<jvm><fail> %>%"></div>
         </div>
     </td>
-    <td><%= $x<distname> %></td>
+    <td><a href="/<%= $url %>"><%= $x<distname> %></a></td>
     <td><%= $x<distauth> || '&lt;unknown&gt;' %></td>
     <td></td>
 </tr>

views/recent-line.tt

@@ -1,5 +1,5 @@
 % my ($x) = @_;
-<tr class="clickableRow" href="/reports/<%= $x<id> %>.html">
+<tr class="clickableRow">
     <td>
         <div class="progress" style="margin-bottom: 0">
             <div class="progress-bar progress-bar-<%=
@@ -12,7 +12,7 @@
             </div>
         </div>
     </td>
-    <td><%= $x<distname> %></td>
+    <td><a href="/reports/<%= $x<id> %>.html"><%= $x<distname> %></a></td>
     <td><%= $x<distver> %></td>
     <td><%= $x<compver> %></td>
     <td><%= $x<backend> %></td>

views/report-line.tt

@@ -1,16 +1,18 @@
 % my ($x) = @_;
-<tr class="clickableRow" href="/reports/<%= $x<id> %>.html">
+<tr class="clickableRow">
     <td>
-        <div class="progress" style="margin-bottom: 0">
-            <div class="progress-bar progress-bar-<%=
-                do given $x<grade> {
-                    when 'PASS' { 'success' }
-                    when 'FAIL' { 'danger'  }
-                    default     { 'warning' }
-                } %>" style="width: 100%">
-                <span><%= $x<grade> %></span>
+        <a href="/reports/<%= $x<id> %>.html">
+            <div class="progress" style="margin-bottom: 0">
+                <div class="progress-bar progress-bar-<%=
+                    do given $x<grade> {
+                        when 'PASS' { 'success' }
+                        when 'FAIL' { 'danger'  }
+                        default     { 'warning' }
+                    } %>" style="width: 100%">
+                    <span><%= $x<grade> %></span>
+                </div>
             </div>
-        </div>
+        </a>
     </td>
     <td><%= $x<compver> %></td>
     <td><%= $x<backend> %></td>