diff --git a/app/app.go b/app/app.go index bb5dcab..54c82f8 100644 --- a/app/app.go +++ b/app/app.go @@ -168,7 +168,15 @@ func (r *Runner) WithTaskHelpers(t ...taskhelper.Helper) *Runner { return r } -func (r *Runner) WithDefaultHTTPServer(metricNamespace string, registerer prometheus.Registerer) *Runner { +func (r *Runner) WithDefaultHTTPServer(metricNamespace string) *Runner { + r.serverBuilder = echo.NewBuilder(addr). + APIRegistration(echo.NewMetricsAPI(true, prometheus.DefaultRegisterer)). + MetricNamespace(metricNamespace). + PrometheusRegisterer(prometheus.DefaultRegisterer) + return r +} + +func (r *Runner) WithDefaultHTTPServerAndPrometheusRegistry(metricNamespace string, registerer prometheus.Registerer) *Runner { r.serverBuilder = echo.NewBuilder(addr). APIRegistration(echo.NewMetricsAPI(true, registerer)). MetricNamespace(metricNamespace). diff --git a/echo/server.go b/echo/server.go index 03b45e4..1eeaeac 100644 --- a/echo/server.go +++ b/echo/server.go @@ -104,8 +104,8 @@ func (b *Builder) Middleware(mdw echo.MiddlewareFunc) *Builder { return b } -// OverrideDefaultMiddleware is setting a flag that will tell if the Builder needs to override the default list of middleware considered by the one provided by the method Middleware -// In case the flag is set at false, then the middleware provided by the user will be append to the default list. +// OverrideDefaultMiddleware is setting a flag that will tell if the Builder needs to override the default list of middleware considered by the one provided by the method Middleware. +// In case the flag is set at false, then the middleware provided by the user will be appended to the default list. // Note that the default list is always executed at the beginning (a.k.a, the default middleware will be executed before yours). func (b *Builder) OverrideDefaultMiddleware(override bool) *Builder { b.overrideMiddleware = override