Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashism in Makefile.am #168

Closed
pete4abw opened this issue Feb 6, 2025 · 0 comments
Closed

bashism in Makefile.am #168

pete4abw opened this issue Feb 6, 2025 · 0 comments
Assignees
@pete4abw
Labels
bug

Comments

@pete4abw
Copy link
Owner

pete4abw commented Feb 6, 2025 •
edited
Loading

As reported here in lrzip by @eli-schwartz : bashism in Makefile.am.

Use of @echo -e in ASM Makefile.am is not compatible with DASH and possibly other shells. Proposed a PR which appears to work. WIll test over here and update accordingly.

Thank you, @eli-schwartz.
@pete4abw pete4abw self-assigned this Feb 6, 2025
@pete4abw pete4abw added the bug label Feb 6, 2025
pete4abw added a commit that referenced this issue Feb 6, 2025
@pete4abw
BUGFIX: #168. As reported by @eli-schwartz. Fix Assembler Makefile.am
a465d8c 
The `@echo -e` command will fail under certain non-bash shells.
PR fix for lrzip uses `printf` command. Added for lrzip-next.

Thank you
@pete4abw pete4abw closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete4abw pete4abw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pete4abw