Skip to content

Commit 9d54e7c

Browse files
committed
Show virtual chassis name in Deviceview card header; fix lint
- ports.html: use object.virtual_chassis.name when device is a VC member instead of the individual member device name - tests/test_utils.py: reformat with black
1 parent 122c1df commit 9d54e7c

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

netbox_device_view/templates/netbox_device_view/ports.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
{% endblock %}
2828
{% block content %}
2929
<div class="card">
30-
<h2 class="card-header">Deviceview {{ object.name }}</h2>
30+
<h2 class="card-header">Deviceview {% if object.virtual_chassis %}{{ object.virtual_chassis.name }}{% else %}{{ object.name }}{% endif %}</h2>
3131
<div class="card-body">
3232
{% spaceless %}
3333
{% if use_svg %}

tests/test_utils.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,10 @@ def test_virtual_chassis_scopes_css(self, MockDV, MockCP):
311311
member2.modules.all.return_value = []
312312

313313
dev = self._make_device(vc=MagicMock())
314-
dev.virtual_chassis.members.select_related.return_value.all.return_value = [member1, member2]
314+
dev.virtual_chassis.members.select_related.return_value.all.return_value = [
315+
member1,
316+
member2,
317+
]
315318

316319
dv, modules, ports_chassis, device_view = prepare(dev)
317320

@@ -339,7 +342,9 @@ def test_virtual_chassis_missing_member_device_view_returns_none(
339342
member.modules.all.return_value = []
340343

341344
dev = self._make_device(vc=MagicMock())
342-
dev.virtual_chassis.members.select_related.return_value.all.return_value = [member]
345+
dev.virtual_chassis.members.select_related.return_value.all.return_value = [
346+
member
347+
]
343348

344349
dv, modules, ports_chassis, device_view = prepare(dev)
345350

0 commit comments

Comments
 (0)