Skip to content

Commit 5bc0709

Browse files
msaroufimamdfaa
authored andcommitted
Enable ROCM in CI (pytorch#999)
* Enable ROCM in CI --------- Co-authored-by: amdfaa <[email protected]>
1 parent 1110405 commit 5bc0709

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.github/workflows/regression_test.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ concurrency:
1717
env:
1818
HF_TOKEN: ${{ secrets.HF_TOKEN }}
1919

20+
permissions:
21+
id-token: write
22+
contents: read
23+
2024
jobs:
2125
test-nightly:
2226
strategy:
@@ -33,13 +37,19 @@ jobs:
3337
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cpu'
3438
gpu-arch-type: "cpu"
3539
gpu-arch-version: ""
40+
- name: ROCM Nightly
41+
runs-on: linux.rocm.gpu.2
42+
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/rocm6.3'
43+
gpu-arch-type: "rocm"
44+
gpu-arch-version: "6.3"
3645

3746
permissions:
3847
id-token: write
3948
contents: read
4049
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
4150
with:
4251
timeout: 120
52+
no-sudo: ${{ matrix.gpu-arch-type == 'rocm' }}
4353
runner: ${{ matrix.runs-on }}
4454
gpu-arch-type: ${{ matrix.gpu-arch-type }}
4555
gpu-arch-version: ${{ matrix.gpu-arch-version }}
@@ -74,7 +84,6 @@ jobs:
7484
torch-spec: 'torch==2.5.1 --index-url https://download.pytorch.org/whl/cu121'
7585
gpu-arch-type: "cuda"
7686
gpu-arch-version: "12.1"
77-
7887
- name: CPU 2.3
7988
runs-on: linux.4xlarge
8089
torch-spec: 'torch==2.3.0 --index-url https://download.pytorch.org/whl/cpu'
@@ -102,8 +111,6 @@ jobs:
102111
conda create -n venv python=3.9 -y
103112
conda activate venv
104113
echo "::group::Install newer objcopy that supports --set-section-alignment"
105-
yum install -y devtoolset-10-binutils
106-
export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
107114
python -m pip install --upgrade pip
108115
pip install ${{ matrix.torch-spec }}
109116
pip install -r dev-requirements.txt

torchao/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ def _torch_version_at_least(min_version):
635635
def is_MI300():
636636
if torch.cuda.is_available() and torch.version.hip:
637637
mxArchName = ["gfx940", "gfx941", "gfx942"]
638-
archName = torch.cuda.get_device_properties().gcnArchName
638+
archName = torch.cuda.get_device_properties(0).gcnArchName
639639
for arch in mxArchName:
640640
if arch in archName:
641641
return True

0 commit comments

Comments
 (0)