Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream or push features to upstream #11

Open
MartyWind opened this issue Sep 18, 2023 · 3 comments
Open

Merge upstream or push features to upstream #11

MartyWind opened this issue Sep 18, 2023 · 3 comments

Comments

@MartyWind
Copy link

Hi there,
I quite like the theme and the changes made to Mainroad.
However the development of Mainroad continues and here it does not.

Would you consider merging upstream?
Bringing the features of this theme to upstream would be even better and you would not have to invest the time maintaining :)

Greetings

@mxmehl
Copy link
Member

mxmehl commented Sep 20, 2023

Thanks for the proposal. I'm afraid we already diverged too much. This theme really is specific to the DPSG layout and the work to integrate this into upstream is not bearable for me time-wise. Also, I'm not sure changes such as 100% local assets are actually wanted upstream, but that's mandatory for the reference implementation of this theme. Would it have been better to put more work into upstream before starting this fork? Certainly.

PRs like #10 increase the gap once again which is why I'm unsure how to handle it.

However, we could sync with upstream again, which may involve resolving some merge conflicts. But again, my time for this project is very limited, but I'd be happy to review a PR.

@MartyWind
Copy link
Author

@mxmehl That's understandable.
I could help with integrating those features once it stands that I will use this theme for my next project (a township in northern germany). But I would split them, to test, review and merge them separately. Merging a big "feature dump" is not a good idea in my opinion.

@mxmehl
Copy link
Member

mxmehl commented Sep 24, 2023

Absolutely, good idea. I hope you will get this next project ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants