fix: fix column unsigned change in update (#108)

fix column unsigned change in update

Co-authored-by: oguzhantogay <[email protected]>

Author: oguzhanT

src/Mvc/Model/Migration.php

@@ -570,6 +570,10 @@ public function morphTable(string $tableName, array $definition): void
                         $changed = true;
                     }
 
+                    if ($localFields[$fieldName]->isUnsigned() != $column->isUnsigned()) {
+                        $changed = true;
+                    }
+
                     if ($changed === true) {
                         try {
                             self::$connection->modifyColumn($tableName, $tableSchema, $column, $column);

tests/_data/issues/109/1.0.0/updateColumnUnsigned.php

@@ -0,0 +1,34 @@
+<?php
+
+use Phalcon\Db\Column;
+use Phalcon\Db\Index;
+use Phalcon\Migrations\Mvc\Model\Migration;
+
+class UpdateColumnUnsignedMigration_100 extends Migration
+{
+    /**
+     * Define the table structure
+     *
+     * @return void
+     * @throws \Phalcon\Db\Exception
+     */
+    public function morph()
+    {
+        $this->morphTable('update_unsigned_column', [
+            'columns' => [
+                new Column(
+                    'id',
+                    [
+                        'type' => Column::TYPE_INTEGER,
+                        'size' => 10,
+                        'unsigned' => true,
+                        'notNull' => true,
+                        'first' => true,
+                        'primary' => true,
+                        'autoIncrement' => true,
+                    ]
+                )
+            ],
+        ]);
+    }
+}

tests/mysql/MigrationsCest.php

@@ -407,6 +407,47 @@ public function generateWithExportOnCreate(MysqlTester $I): void
         );
     }
 
+    public function updateColumnUnsigned(MysqlTester $mysqlTester): void
+    {
+        $dbName = getenv('MYSQL_TEST_DB_DATABASE');
+        $tableName = 'update_unsigned_column';
+        $migrationsDir = codecept_output_dir(__FUNCTION__);
+
+        $mysqlTester->getPhalconDb()->createTable($tableName, $dbName, [
+            'columns' => [
+                new Column('id', [
+                  'type' => Column::TYPE_INTEGER,
+                  'size' => 10,
+                  'unsigned' => false,
+                  'notNull' => true,
+                  'first' => true,
+                  'primary' => true,
+                  'autoIncrement' => true,
+                ]),
+            ],
+        ]);
+
+        ob_start();
+        Migrations::generate([
+          'migrationsDir' => $migrationsDir,
+          'config' => $mysqlTester->getMigrationsConfig(),
+          'tableName' => '@',
+        ]);
+        ob_clean();
+
+        ob_start();
+        Migrations::run([
+          'migrationsDir' => codecept_data_dir('issues/109'),
+          'config' => $mysqlTester->getMigrationsConfig(),
+          'migrationsInDb' => true,
+        ]);
+        ob_clean();
+
+        $columns = $mysqlTester->getPhalconDb()->describeColumns($tableName);
+
+        $mysqlTester->asserttrue($columns[0]->isUnsigned());
+    }
+
     public function nullableTimestamp(MysqlTester $I): void
     {
         $dbName = getenv('MYSQL_TEST_DB_DATABASE');