Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Speed up testing #1295

Open
rsetaluri opened this issue Jul 27, 2023 · 1 comment
Open

[CI] Speed up testing #1295

rsetaluri opened this issue Jul 27, 2023 · 1 comment

Comments

@rsetaluri
Copy link
Collaborator

Here are some ideas for speeding up our testing:

  • Use mlir-verilog by default rather than coreir-verilog. I believe this is already a goal of magma 3.0.
  • Avoid compilation when possible. I.e. use circuit properties or repr when possible. Ideally compilation should only check the backend, not in-memory properties.
    • If compilation is necessary, compile to the IR only when possible (i.e. avoid compiling to verilog). Verilog compilation should be reserved for features which are very specific to verilog.
  • Move functional tests (e.g. those that use verilator or fault) to an integration testing suite that runs nightly.
@leonardt
Copy link
Collaborator

For functional test, one approach is to regress on a representation (depending on the goal, could check magma repr, or MLIR, or verilog). If it changes, run the functional test and update the golds if it passes. This would avoid functional tests in the standard CI, but running those on a schedule may also be worthwhile to detect other changes (e.g. simulator changes affecting the tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants