Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: do not use #notNil, use #isNotNil instead #95

Closed
astares opened this issue May 16, 2024 · 2 comments · Fixed by #96
Closed

Cleanup: do not use #notNil, use #isNotNil instead #95

astares opened this issue May 16, 2024 · 2 comments · Fixed by #96

Comments

@astares
Copy link
Contributor

astares commented May 16, 2024

We have three cases in Sindarin where #notNil is sent instead of #isNotNil
Our plan is to deprecated #notNil in Pharo 13 so we would like to cleanup all senders first.

Screenshot from 2024-05-16 20 21 43

see pharo-project/pharo#15118
astares added a commit to astares/ScriptableDebugger that referenced this issue May 16, 2024
@astares
Cleanup: do not use #notNil, use #isNotNil instead
18b9e5b 
Fix pharo-spec#95
@astares astares mentioned this issue May 16, 2024
Merged
@astares
Copy link
Contributor Author

astares commented May 16, 2024

@StevenCostiou would you be able to check and if OK merge this one

@jecisc
Copy link
Member

jecisc commented May 21, 2024

Done

@jecisc jecisc closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: do not use #notNil, use #isNotNil instead astares/ScriptableDebugger
2 participants
@astares @jecisc