Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#![feature(const_mut_refs)] stable since 1.83 #1370

Closed
woile opened this issue Jan 3, 2025 · 4 comments · Fixed by #1376
Closed

#![feature(const_mut_refs)] stable since 1.83 #1370

woile opened this issue Jan 3, 2025 · 4 comments · Fixed by #1376

Comments

@woile
Copy link

woile commented Jan 3, 2025

The compiler now warns:

the feature const_mut_refs has been stable since 1.83.0 and no longer requires an attribute to enable

Recommendations

  1. remove the feature from the blog posts
  2. rephrase from:
you also need to add #![feature(const_mut_refs)] to the top of your lib.rs

to

you may need to add #![feature(const_mut_refs)] to the top of your lib.rs if you are running rust older than `1.83.0`

I can submit a PR if you want after I finish the series 👍🏻 thanks for this project, I've loved it so far

@AtomicGamer9523
Copy link

Thanks for the heads up. However, not everyone is on the latest nightly version, so I believe it may be more clear if it is phrased to something along the lines of "you also need to add #![feature(const_mut_refs)] to the top of your lib.rs. However, if you are rust 1.83 or newer, that is no longer mandatory"

@woile
Copy link
Author

woile commented Jan 3, 2025

What do you mean by the latest nightly? the latest nightly is 1.85 and the current stable is 1.83

@AtomicGamer9523
Copy link

I am sorry, let me rephrase that. Not everyone automatically updates their rust versions. In fact, most people still haven't probably installed the 1.83 version. For that reason I suggest you assume most haven't, and structure the sentence as such. But feel free to disregard this remark.

@phil-opp
Copy link
Owner

Thanks for reporting! I opened #1376 to remove that paragraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants