Independent k/q meshes in RTA case, improve storage of velocities in memory #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, also do not store group velocities for intermediate bands in the case where adaptive smearing is not used (at least, for el transport)
…in el wannier app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to allow the code to scale to larger system sizes, including more conservative allocation of band velocities for intermediate phonon states when using the RTA for electrons, and also the ability to use separate k and q meshes in the RTA electron BTE case.
Further acceleration of the intermediate phonon state calculation when using RTA with different k/q should be investigated. Using the Kokkos batched functions with chunks of q points would be faster than the current implementation.
Thanks to @MSimoncelli and @SiyuChen for pointing out the need for this in Issue #225