Added functional tests to make sure the bundle work on different sf versions (#40)

* Added functional tests to make sure the bundle work on different symfony versions

* Applied fixes from StyleCI (#41)

* Updated comment

* Do not run travis on Style CI branches

Author: Nyholm

.travis.yml

@@ -17,6 +17,10 @@ env:
     - SYMFONY_VERSION=2.8.*
     - SYMFONY_VERSION=3.0.*
 
+branches:
+  except:
+    - /^analysis-.*$/
+
 matrix:
   fast_finish: true
   include:

composer.json

@@ -18,14 +18,15 @@
         }
     ],
     "require": {
-        "php":                      "^5.5|^7",
-        "symfony/framework-bundle": "^2.7|^3.0",
-        "symfony/options-resolver": "^2.7|^3.0",
-        "psr/cache":                "1.0.0"
+        "php":                      "^5.5 || ^7.0",
+        "symfony/framework-bundle": "^2.7 || ^3.0",
+        "symfony/options-resolver": "^2.7 || ^3.0",
+        "psr/cache":                "^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "5.0.*|^4.0",
-        "matthiasnoback/symfony-dependency-injection-test": "0.7.*",
+        "phpunit/phpunit": "5.0.* || ^4.0",
+        "symfony/symfony": "^2.7 || ^3.0",
+        "matthiasnoback/symfony-dependency-injection-test": "^1.0",
         "cache/array-adapter": "@stable"
     },
     "suggest": {

phpunit.xml.dist

@@ -12,15 +12,11 @@
   bootstrap="vendor/autoload.php"
   >
   <testsuites>
-    <testsuite name="CacheBundle for the Symfony2 Framework">
+    <testsuite name="Main testsuite for AdapterBundle">
       <directory>./tests/</directory>
     </testsuite>
   </testsuites>
 
-  <logging>
-    <log type="coverage-text" target="php://stdout"/>
-  </logging>
-
   <groups>
     <exclude>
       <group>benchmark</group>

src/DSN.php

@@ -229,7 +229,7 @@ private function parseHosts($hostString)
 
         $hosts = [];
         foreach ($matches['host'] as $index => $match) {
-            $port    = !empty($matches['port'][$index])
+            $port = !empty($matches['port'][$index])
                 ? (int) $matches['port'][$index]
                 : self::$PORTS[$this->protocol];
             $hosts[] = ['host' => $match, 'port' => $port];

src/Factory/DoctrineRedisFactory.php

@@ -25,7 +25,7 @@ class DoctrineRedisFactory extends AbstractDoctrineAdapterFactory
      */
     public function getAdapter(array $config)
     {
-        $redis  = new \Redis();
+        $redis = new \Redis();
         $redis->connect($config['host'], $config['port']);
 
         $client = new RedisCache();

src/Factory/MemcacheFactory.php

@@ -41,8 +41,8 @@ public function getAdapter(array $config)
     protected static function configureOptionResolver(OptionsResolver $resolver)
     {
         $resolver->setDefaults([
-          'host'     => '127.0.0.1',
-          'port'     => 11211,
+          'host' => '127.0.0.1',
+          'port' => 11211,
         ]);
 
         $resolver->setAllowedTypes('host', ['string']);

tests/Functional/BaseTestCase.php

@@ -0,0 +1,33 @@
+<?php
+
+/*
+ * This file is part of php-cache organization.
+ *
+ * (c) 2015-2015 Aaron Scherer <[email protected]>, Tobias Nyholm <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Cache\AdapterBundle\Tests\Functional;
+
+use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+
+class BaseTestCase extends WebTestCase
+{
+    protected static function getKernelClass()
+    {
+        require_once __DIR__.'/app/AppKernel.php';
+
+        return 'Cache\AdapterBundle\Tests\Functional\app\AppKernel';
+    }
+
+    protected static function createKernel(array $options = [])
+    {
+        $class = self::getKernelClass();
+
+        return new $class(
+            isset($options['config']) ? $options['config'] : 'default.yml'
+        );
+    }
+}

tests/Functional/BundleInitializationTest.php

@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of php-cache organization.
+ *
+ * (c) 2015-2015 Aaron Scherer <[email protected]>, Tobias Nyholm <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Cache\AdapterBundle\Tests\Functional;
+
+class BundleInitializationTest extends BaseTestCase
+{
+    public function testRegisterBundle()
+    {
+        static::createClient();
+    }
+}

tests/Functional/app/AppKernel.php

@@ -0,0 +1,66 @@
+<?php
+
+/*
+ * This file is part of php-cache organization.
+ *
+ * (c) 2015-2015 Aaron Scherer <[email protected]>, Tobias Nyholm <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Cache\AdapterBundle\Tests\Functional\app;
+
+use Symfony\Component\Config\Loader\LoaderInterface;
+use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\HttpKernel\Kernel;
+
+class AppKernel extends Kernel
+{
+    private $config;
+
+    public function __construct($config)
+    {
+        parent::__construct('test', true);
+
+        $fs = new Filesystem();
+
+        if (!$fs->isAbsolutePath($config)) {
+            $config = __DIR__.'/config/'.$config;
+        }
+
+        if (!file_exists($config)) {
+            throw new \RuntimeException(sprintf('The config file "%s" does not exist', $config));
+        }
+
+        $this->config = $config;
+    }
+
+    public function registerBundles()
+    {
+        return [
+            new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
+            new \Cache\AdapterBundle\CacheAdapterBundle(),
+        ];
+    }
+
+    public function registerContainerConfiguration(LoaderInterface $loader)
+    {
+        $loader->load($this->config);
+    }
+
+    public function getCacheDir()
+    {
+        return sys_get_temp_dir().'/TestBundle';
+    }
+
+    public function serialize()
+    {
+        return $this->config;
+    }
+
+    public function unserialize($config)
+    {
+        $this->__construct($config);
+    }
+}

tests/Functional/app/config/default.yml

@@ -0,0 +1,9 @@
+imports:
+    - { resource: framework.yml }
+
+cache_adapter:
+  providers:
+    my_adapter:
+      factory: 'cache.factory.array'
+      options: []
+      aliases: ['alias.my_adapter']

tests/Functional/app/config/framework.yml

@@ -0,0 +1,11 @@
+framework:
+    secret: test
+    test: ~
+    session:
+        storage_id: session.storage.mock_file
+    form: false
+    csrf_protection: false
+    validation:
+        enabled: false
+    router:
+        resource: "%kernel.root_dir%/config/routing.yml"

tests/Functional/app/config/routing.yml

@@ -9,7 +9,7 @@
  * with this source code in the file LICENSE.
  */
 
-namespace Cache\Adapter\DoctrineAdapterBundle\Tests\DependencyInjection;
+namespace Cache\AdapterBundle\Tests\Unit\DependencyInjection;
 
 use Cache\AdapterBundle\DependencyInjection\CacheAdapterExtension;
 use Cache\AdapterBundle\DummyAdapter;

tests/DependencyInjection/DoctrineCacheExtensionTest.php tests/Unit/DependencyInjection/DoctrineCacheExtensionTest.php

@@ -9,7 +9,7 @@
  * with this source code in the file LICENSE.
  */
 
-namespace Cache\Adapter\DoctrineAdapterBundle\Tests;
+namespace Cache\AdapterBundle\Tests\Unit;
 
 use Cache\AdapterBundle\DSN;