Skip to content

Commit db5b4c2

Browse files
committed
chore: don't test Go implementation for 500 errors
As we don't have a generic error handler, there is no reason to have a test for such behavior. Part of #48
1 parent b10946d commit db5b4c2

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/integration-tests.yml

+5
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,19 @@ jobs:
3434
- docker-service-name: 'express-js'
3535
database-service-name: 'mysql'
3636
application-port: 3010
37+
skip_500_error_testing: false
3738
- docker-service-name: 'express-ts'
3839
database-service-name: 'mysql'
3940
application-port: 3020
41+
skip_500_error_testing: false
4042
- docker-service-name: 'chi'
4143
database-service-name: 'mysql'
4244
application-port: 3030
45+
skip_500_error_testing: true
4346
- docker-service-name: 'fastapi'
4447
database-service-name: 'postgres'
4548
application-port: 4040
49+
skip_500_error_testing: false
4650
env:
4751
# Prevent interference between builds by setting the project name to a unique value. Otherwise
4852
# "docker compose down" has been stopping containers (especially database) from other builds.
@@ -92,6 +96,7 @@ jobs:
9296
hurl \
9397
--error-format long \
9498
--variable SERVER_URL=http://127.0.0.1:${{ matrix.application-port }} \
99+
--variable skip_500_error_testing=${{ matrix.skip_500_error_testing }} \
95100
--test \
96101
tests/crud.hurl \
97102
tests/misc.hurl

tests/misc.hurl

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Tests for various operations
33
#
44
# How to run:
5-
# hurl --variable SERVER_URL=http://127.0.0.1:3000 misc.hurl --test
5+
# hurl --variable SERVER_URL=http://127.0.0.1:3000 --variable skip_500_error_testing=false misc.hurl --test
66
#
77

88

@@ -14,6 +14,8 @@ jsonpath "$.custom" == true
1414

1515

1616
GET {{ SERVER_URL }}/custom/exception
17+
[Options]
18+
skip: {{ skip_500_error_testing }}
1719
HTTP 500
1820
[Asserts]
1921
header "Content-Type" contains "application/json"

0 commit comments

Comments
 (0)