Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing current TokenParser #26

Closed
nick-zh opened this issue Dec 8, 2021 · 1 comment · Fixed by #34
Closed

Consider replacing current TokenParser #26

nick-zh opened this issue Dec 8, 2021 · 1 comment · Fixed by #34
Labels
next-major
Milestone
v3.0.0

Comments

@nick-zh
Copy link
Member

nick-zh commented Dec 8, 2021

TokenParser was pieced together from other projects.
Evaluate if it would be feasible to replace it with something that is better maintained like PHP-Parser
@nick-zh nick-zh added this to the v3.0.0 milestone Dec 8, 2021
This was referenced Dec 8, 2021
Closed
Closed
Open
@nick-zh nick-zh linked a pull request Dec 15, 2021 that will close this issue
refactor token parser #34
Merged
@nick-zh
Copy link
Member Author

nick-zh commented Dec 15, 2021 •
edited
Loading

It seems that this should be feasible, i will split it into:

  • class parser
  • property parser

and provide some interfaces, so it is possible to customize the behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-major
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

refactor token parser php-kafka/php-avro-schema-generator
1 participant
@nick-zh