Run CI with all backends

Author: mvorisek

.github/workflows/test-unit.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: ['7.4', '8.0', '8.1', '8.2', '8.3', 'latest']
+        php: ['latest']
         type: ['Phpunit']
         include:
           - php: 'latest'
@@ -55,3 +55,80 @@ jobs:
         run: |
           echo "memory_limit = 2G" > /usr/local/etc/php/conf.d/custom-memory-limit.ini
           vendor/bin/phpstan analyse -v
+
+  unit-test:
+    name: Unit
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/mvorisek/image-php:${{ matrix.php }}
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.4', '8.0', '8.1', '8.2', '8.3']
+        type: ['Phpunit', 'Phpunit Lowest']
+    env:
+      LOG_COVERAGE: "${{ fromJSON('{true: \"1\", false: \"\"}')[matrix.php == '8.3' && matrix.type == 'Phpunit' && (github.event_name == 'pull_request' || (github.event_name == 'push' && (github.ref == 'refs/heads/develop' || github.ref == 'refs/heads/master')))] }}"
+    services:
+      mysql:
+        image: mysql
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5 -e MYSQL_ROOT_PASSWORD=test_pass_root -e MYSQL_USER=test_user -e MYSQL_PASSWORD=test_pass -e MYSQL_DATABASE=test_db
+      postgres:
+        image: postgres:12-alpine
+        env:
+          POSTGRES_USER: test_user
+          POSTGRES_PASSWORD: test_pass
+          POSTGRES_DB: test_db
+        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+      redis1:
+        image: redis:alpine
+      redis2:
+        image: redis:alpine
+      redis3:
+        image: redis:alpine
+      memcached:
+        image: memcached:alpine
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Configure PHP
+        run: |
+          install-php-extensions lzf memcached sysvsem
+          if [ -n "$LOG_COVERAGE" ]; then echo "xdebug.mode=coverage" >> /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; else rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini; fi
+          php --version
+
+      - name: Install PHP dependencies
+        run: |
+          if [ "${{ matrix.type }}" != "Phpunit" ] && [ "${{ matrix.type }}" != "Phpunit Lowest" ]; then composer remove --no-interaction --no-update phpunit/phpunit ergebnis/phpunit-slow-test-detector --dev; fi
+          if [ "${{ matrix.type }}" != "CodingStyle" ]; then composer remove --no-interaction --no-update friendsofphp/php-cs-fixer ergebnis/composer-normalize --dev; fi
+          if [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpstan/\* --dev; fi
+          if [ -n "$LOG_COVERAGE" ]; then composer require --no-interaction --no-install phpunit/phpcov; fi
+          composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader
+          if [ "${{ matrix.type }}" = "Phpunit Lowest" ]; then composer update --ansi --prefer-dist --prefer-lowest --prefer-stable --no-interaction --no-progress --optimize-autoloader; fi
+
+      - name: Init
+        run: |
+          php -r '(new PDO("mysql:host=mysql", "root", "test_pass_root"))->exec("ALTER USER '"'"'test_user'"'"'@'"'"'%'"'"' WITH MAX_USER_CONNECTIONS 15");'
+          php -r '(new PDO("pgsql:host=postgres;dbname=test_db", "test_user", "test_pass"))->exec("ALTER ROLE test_user CONNECTION LIMIT 1");'
+          if [ -n "$LOG_COVERAGE" ]; then mkdir coverage; fi
+
+      - name: "Run tests"
+        env:
+          MYSQL_DSN: "mysql:host=mysql;dbname=test_db"
+          MYSQL_USER: test_user
+          MYSQL_PASSWORD: test_pass
+          PGSQL_DSN: "pgsql:host=postgres;dbname=test_db"
+          PGSQL_USER: test_user
+          PGSQL_PASSWORD: test_pass
+          REDIS_URIS: "redis://redis1,redis://redis2,redis://redis3"
+          MEMCACHE_HOST: memcached
+        run: |
+          php -d opcache.enable_cli=1 vendor/bin/phpunit --exclude-group none $(if [ -n "$LOG_COVERAGE" ]; then echo --coverage-text; else echo --no-coverage; fi) --fail-on-warning --fail-on-risky $(if vendor/bin/phpunit --version | grep -q '^PHPUnit 9\.'; then echo -v; else echo --fail-on-notice --fail-on-deprecation --display-notices --display-deprecations --display-warnings --display-errors --display-incomplete --display-skipped; fi)
+
+      - name: Upload coverage (only for coverage)
+        if: env.LOG_COVERAGE && false # TODO
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          fail_ci_if_error: true
+          files: coverage/phpunit.cov

phpstan.neon.dist

@@ -11,11 +11,6 @@ parameters:
 
     ignoreErrors:
         # TODO
-        -
-            path: '*'
-            identifier: equal.notAllowed
-            message: '~^Loose comparison via "==" is not allowed\.$~'
-            count: 4
         -
             path: 'src/mutex/RedisMutex.php'
             identifier: if.condNotBoolean

src/mutex/MySQLMutex.php

@@ -48,7 +48,7 @@ public function lock(): void
         $statement->setFetchMode(\PDO::FETCH_NUM);
         $row = $statement->fetch();
 
-        if ($row[0] == 1) {
+        if ((string) $row[0] === '1') {
             // Returns 1 if the lock was obtained successfully.
             return;
         }

tests/mutex/MutexConcurrencyTest.php

@@ -88,8 +88,6 @@ private function fork(int $concurrency, callable $code): void
      * @param callable $mutexFactory the mutex factory
      *
      * @dataProvider provideHighContentionCases
-     *
-     * @slowThreshold 1000
      */
     public function testHighContention(callable $code, callable $mutexFactory): void
     {
@@ -153,9 +151,9 @@ static function (int $increment) use ($filename): int {
             self::$pdo = null;
 
             $cases[$vendor] = [
-                static function ($increment) use ($dsn, $user, $password) {
+                static function (int $increment) use ($dsn, $user, $password) {
                     // This prevents using a closed connection from a child.
-                    if ($increment == 0) {
+                    if ($increment === 0) {
                         self::$pdo = null;
                     }
                     $pdo = self::getPDO($dsn, $user, $password);
@@ -203,8 +201,6 @@ static function ($timeout = 3) use ($dsn, $user, $password) {
      * @param callable $mutexFactory the Mutex factory
      *
      * @dataProvider provideExecutionIsSerializedWhenLockedCases
-     *
-     * @slowThreshold 2000
      */
     public function testExecutionIsSerializedWhenLocked(callable $mutexFactory): void
     {

tests/util/DoubleCheckedLockingTest.php

@@ -58,7 +58,7 @@ public function testLockedCheckAndExecution(): void
             });
 
         $checkedLocking = new DoubleCheckedLocking($this->mutex, static function () use (&$lock, &$check): bool {
-            if ($check == 1) {
+            if ($check === 1) {
                 self::assertSame(1, $lock);
             }
             ++$check;
@@ -117,7 +117,7 @@ public static function provideCodeNotExecutedCases(): iterable
             }],
 
             [static function () use (&$checkCounter): bool {
-                $result = $checkCounter == 0;
+                $result = $checkCounter === 0;
                 ++$checkCounter;
 
                 return $result;