Error message if old PERSISTENT=n flag is used in session.save_path

Author: sodabrew

Diff for: package.xml

@@ -117,6 +117,7 @@ Fixes
     <file role='test' name='rescode.phpt'/>
     <file role='test' name='session_badconf_emptyprefix.phpt'/>
     <file role='test' name='session_badconf_locktime.phpt'/>
+    <file role='test' name='session_badconf_persistent.phpt'/>
     <file role='test' name='session_badconf_prefix.phpt'/>
     <file role='test' name='session_badconf_servers.phpt'/>
     <file role='test' name='session_badconf_servers-php72.phpt'/>

Diff for: php_memcached_session.c

@@ -319,6 +319,13 @@ PS_OPEN_FUNC(memcached)
 
 	memcached_server_list_st servers;
 
+	// Fail on incompatible PERSISTENT identifier (removed in php-memcached 3.0)
+	if (strstr(save_path, "PERSISTENT=")) {
+		php_error_docref(NULL, E_WARNING, "failed to parse session.save_path: PERSISTENT is replaced by memcached.sess_persistent = On");
+		PS_SET_MOD_DATA(NULL);
+		return FAILURE;
+	}
+
 	// First parse servers
 	servers = memcached_servers_parse(save_path);
 

Diff for: tests/session_badconf_persistent.phpt

@@ -0,0 +1,25 @@
+--TEST--
+Session bad configurations, persistent
+--SKIPIF--
+<?php
+include dirname(__FILE__) . "/skipif.inc";
+if (!Memcached::HAVE_SESSION) print "skip";
+?>
+--INI--
+session.save_handler = "memcached"
+session.save_path = "PERSISTENT=1 hello:11211,world:11211"
+
+--FILE--
+<?php
+ob_start();
+
+session_start();
+session_write_close();
+
+echo "OK";
+
+--EXPECTF--
+Warning: session_start(): failed to parse session.save_path: PERSISTENT is replaced by memcached.sess_persistent = On in %s on line %d
+
+Warning: session_start(): Failed to initialize storage module: memcached (path: PERSISTENT=1 %s) in %s on line %d
+OK