Skip to content

Commit 957024f

Browse files
committed
Consistently use #ifdef instead of #if for autoconf definitions
1 parent 5bcf200 commit 957024f

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

php_memcached.c

+8-8
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ typedef struct {
155155
zend_long store_retry_count;
156156
zend_long set_udf_flags;
157157

158-
#if HAVE_MEMCACHED_SASL
158+
#ifdef HAVE_MEMCACHED_SASL
159159
zend_bool has_sasl_data;
160160
#endif
161161
} php_memc_user_data_t;
@@ -243,7 +243,7 @@ static zend_object_handlers memcached_server_object_handlers;
243243
static zend_class_entry *memcached_server_ce = NULL;
244244
#endif
245245

246-
#if HAVE_SPL
246+
#ifdef HAVE_SPL
247247
static zend_class_entry *spl_ce_RuntimeException = NULL;
248248
#endif
249249

@@ -431,7 +431,7 @@ static
431431

432432
zend_bool php_memc_init_sasl_if_needed()
433433
{
434-
#if HAVE_MEMCACHED_SASL
434+
#ifdef HAVE_MEMCACHED_SASL
435435
if (MEMC_G(sasl_initialised)) {
436436
return 1;
437437
}
@@ -3273,7 +3273,7 @@ static PHP_METHOD(Memcached, isPristine)
32733273
static
32743274
void php_memc_destroy(memcached_st *memc, php_memc_user_data_t *memc_user_data)
32753275
{
3276-
#if HAVE_MEMCACHED_SASL
3276+
#ifdef HAVE_MEMCACHED_SASL
32773277
if (memc_user_data->has_sasl_data) {
32783278
memcached_destroy_sasl_auth_data(memc);
32793279
}
@@ -3597,7 +3597,7 @@ zend_class_entry *php_memc_get_exception(void)
35973597
PHP_MEMCACHED_API
35983598
zend_class_entry *php_memc_get_exception_base(int root)
35993599
{
3600-
#if HAVE_SPL
3600+
#ifdef HAVE_SPL
36013601
if (!root) {
36023602
if (!spl_ce_RuntimeException) {
36033603
zend_class_entry *pce;
@@ -4311,7 +4311,7 @@ static void php_memc_register_constants(INIT_FUNC_ARGS)
43114311
REGISTER_MEMC_CLASS_CONST_LONG(RES_SERVER_MEMORY_ALLOCATION_FAILURE, MEMCACHED_SERVER_MEMORY_ALLOCATION_FAILURE);
43124312
#endif
43134313

4314-
#if HAVE_MEMCACHED_SASL
4314+
#ifdef HAVE_MEMCACHED_SASL
43154315
REGISTER_MEMC_CLASS_CONST_LONG(RES_AUTH_PROBLEM, MEMCACHED_AUTH_PROBLEM);
43164316
REGISTER_MEMC_CLASS_CONST_LONG(RES_AUTH_FAILURE, MEMCACHED_AUTH_FAILURE);
43174317
REGISTER_MEMC_CLASS_CONST_LONG(RES_AUTH_CONTINUE, MEMCACHED_AUTH_CONTINUE);
@@ -4437,7 +4437,7 @@ PHP_MINIT_FUNCTION(memcached)
44374437
/* {{{ PHP_MSHUTDOWN_FUNCTION */
44384438
PHP_MSHUTDOWN_FUNCTION(memcached)
44394439
{
4440-
#if HAVE_MEMCACHED_SASL
4440+
#ifdef HAVE_MEMCACHED_SASL
44414441
if (MEMC_G(sasl_initialised)) {
44424442
sasl_done();
44434443
}
@@ -4456,7 +4456,7 @@ PHP_MINFO_FUNCTION(memcached)
44564456
php_info_print_table_row(2, "Version", PHP_MEMCACHED_VERSION);
44574457
php_info_print_table_row(2, "libmemcached version", memcached_lib_version());
44584458

4459-
#if HAVE_MEMCACHED_SASL
4459+
#ifdef HAVE_MEMCACHED_SASL
44604460
php_info_print_table_row(2, "SASL support", "yes");
44614461
#else
44624462
php_info_print_table_row(2, "SASL support", "no");

php_memcached_private.h

+8-8
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,15 @@ typedef struct {
9393
php_memc_serializer_type type;
9494
} php_memc_serializer;
9595

96-
#ifdef HAVE_MEMCACHED_IGBINARY
97-
#define SERIALIZER_DEFAULT SERIALIZER_IGBINARY
98-
#define SERIALIZER_DEFAULT_NAME "igbinary"
99-
#elif HAVE_MEMCACHED_MSGPACK
100-
#define SERIALIZER_DEFAULT SERIALIZER_MSGPACK
101-
#define SERIALIZER_DEFAULT_NAME "msgpack"
96+
#if defined(HAVE_MEMCACHED_IGBINARY)
97+
# define SERIALIZER_DEFAULT SERIALIZER_IGBINARY
98+
# define SERIALIZER_DEFAULT_NAME "igbinary"
99+
#elif defined(HAVE_MEMCACHED_MSGPACK)
100+
# define SERIALIZER_DEFAULT SERIALIZER_MSGPACK
101+
# define SERIALIZER_DEFAULT_NAME "msgpack"
102102
#else
103-
#define SERIALIZER_DEFAULT SERIALIZER_PHP
104-
#define SERIALIZER_DEFAULT_NAME "php"
103+
# define SERIALIZER_DEFAULT SERIALIZER_PHP
104+
# define SERIALIZER_DEFAULT_NAME "php"
105105
#endif /* HAVE_MEMCACHED_IGBINARY / HAVE_MEMCACHED_MSGPACK */
106106

107107
#ifdef HAVE_MEMCACHED_SASL

php_memcached_session.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ void s_destroy_mod_data(memcached_st *memc)
6868
{
6969
php_memcached_user_data *user_data = memcached_get_user_data(memc);
7070

71-
#if HAVE_MEMCACHED_SASL
71+
#ifdef HAVE_MEMCACHED_SASL
7272
if (user_data->has_sasl_data) {
7373
memcached_destroy_sasl_auth_data(memc);
7474
}

0 commit comments

Comments
 (0)