Skip to content

Commit 77c5501

Browse files
authored
Merge pull request #4 from php-middleware/use-compatibility-tool
Use double-pass-compatibility
2 parents 6e94208 + c5896cd commit 77c5501

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

composer.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
"psr/log": "^1.0",
1818
"psr/http-message": "^1.0",
1919
"zendframework/zend-diactoros": "^1.4",
20-
"http-interop/http-middleware": "^0.4.1"
20+
"http-interop/http-middleware": "^0.4.1",
21+
"php-middleware/double-pass-compatibility": "^1.0"
2122
},
2223
"require-dev": {
2324
"phpunit/phpunit": "^6.1"

src/LogMiddleware.php

+5-16
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use Interop\Http\ServerMiddleware\DelegateInterface;
88
use Interop\Http\ServerMiddleware\MiddlewareInterface;
9+
use PhpMiddleware\DoublePassCompatibilityTrait;
910
use PhpMiddleware\LogHttpMessages\Formatter\ResponseFormatter;
1011
use PhpMiddleware\LogHttpMessages\Formatter\ServerRequestFormatter;
1112
use Psr\Http\Message\ResponseInterface as Response;
@@ -15,6 +16,8 @@
1516

1617
final class LogMiddleware implements MiddlewareInterface
1718
{
19+
use DoublePassCompatibilityTrait;
20+
1821
const LOG_MESSAGE = 'Request/Response';
1922

2023
private $logger;
@@ -37,32 +40,18 @@ public function __construct(
3740
$this->logMessage = $logMessage;
3841
}
3942

40-
public function __invoke(ServerRequest $request, Response $response, callable $next) : Response
41-
{
42-
$outResponse = $next($request, $response);
43-
44-
$this->logMessages($request, $outResponse);
45-
46-
return $outResponse;
47-
}
48-
4943
public function process(ServerRequest $request, DelegateInterface $delegate) : Response
5044
{
5145
$response = $delegate->process($request);
5246

53-
$this->logMessages($request, $response);
54-
55-
return $response;
56-
}
57-
58-
private function logMessages(ServerRequest $request, Response $response)
59-
{
6047
$formattedRequest = $this->requestFormatter->formatServerRequest($request);
6148
$formattedResponse = $this->responseFormatter->formatResponse($response);
6249

6350
$this->logger->log($this->level, $this->logMessage, [
6451
'request' => $formattedRequest->getValue(),
6552
'response' => $formattedResponse->getValue(),
6653
]);
54+
55+
return $response;
6756
}
6857
}

0 commit comments

Comments
 (0)