Skip to content

Commit a0e3fdf

Browse files
committed
Make separate factories for all services
1 parent 1f02a97 commit a0e3fdf

File tree

3 files changed

+33
-4
lines changed

3 files changed

+33
-4
lines changed

Diff for: src/JavascriptRendererFactory.php

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
<?php
2+
3+
namespace PhpMiddleware\PhpDebugBar;
4+
5+
use DebugBar\JavascriptRenderer;
6+
7+
final class JavascriptRendererFactory
8+
{
9+
public function __invoke()
10+
{
11+
$standardDebugBarFactory = new StandardDebugBarFactory();
12+
$debugbar = $standardDebugBarFactory();
13+
14+
$renderer = new JavascriptRenderer($debugbar, '/phpdebugbar');
15+
16+
return $renderer;
17+
}
18+
}

Diff for: src/PhpDebugBarMiddlewareFactory.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
namespace PhpMiddleware\PhpDebugBar;
44

5-
use DebugBar\StandardDebugBar;
6-
75
/**
86
* Default, simple factory for middleware
97
*
@@ -13,8 +11,8 @@ final class PhpDebugBarMiddlewareFactory
1311
{
1412
public function __invoke()
1513
{
16-
$debugbar = new StandardDebugBar();
17-
$renderer = $debugbar->getJavascriptRenderer('/phpdebugbar');
14+
$rendererFactory = new JavascriptRendererFactory();
15+
$renderer = $rendererFactory();
1816

1917
return new PhpDebugBarMiddleware($renderer);
2018
}

Diff for: src/StandardDebugBarFactory.php

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
3+
namespace PhpMiddleware\PhpDebugBar;
4+
5+
use DebugBar\StandardDebugBar;
6+
7+
final class StandardDebugBarFactory
8+
{
9+
public function __invoke()
10+
{
11+
return new StandardDebugBar();
12+
}
13+
}

0 commit comments

Comments
 (0)