Merge pull request #4 from php-openapi-tools/no-loading-slash-for-namespaces

No leading slashes for namespaces

Author: WyriHaximus

etc/qa/phpstan.neon

@@ -2,6 +2,7 @@ parameters:
 	ignoreErrors:
 		- '#Access to an undefined property OpenAPITools\\Contract\\Package::#'
 		- '#Parameter \#2 \$haystack of static method PHPUnit\\Framework\\Assert::assertStringContainsString\(\) expects string, PhpParser\\Node\|string given.#'
+		- '#Parameter \#2 \$haystack of static method PHPUnit\\Framework\\Assert::assertStringNotContainsString\(\) expects string, PhpParser\\Node\|string given.#'
 		- '#extends PHPUnit\\Framework\\TestCase, is concrete, but does not have a Test suffix.#'
 includes:
 	- ../../vendor/wyrihaximus/test-utilities/rules.neon

src/Hydrator.php

@@ -23,6 +23,7 @@
 use function array_map;
 use function array_unique;
 use function count;
+use function trim;
 use function ucfirst;
 
 final readonly class Hydrator implements FileGenerator
@@ -76,7 +77,7 @@ public function generate(Package $package, Representation\Namespaced\Representat
                             static fn (string $className): bool => count((new ReflectionMethod($className, '__construct'))->getParameters()) > 0,
                         ),
                     ),
-                    $hydrator->className->fullyQualified->source,
+                    trim($hydrator->className->fullyQualified->source, '\\'),
                 ),
                 File::DO_LOAD_ON_WRITE,
             );

tests/DataTests/Basic.php

@@ -16,13 +16,15 @@ public static function assert(File ...$files): void
         self::assertArrayHasKey('Internal\Hydrators', $files);
         self::assertArrayHasKey('Internal\Hydrator\Operation\Root', $files);
 
+        self::assertStringNotContainsString('namespace \\', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('public function hydrateObject(string $className, array $payload) : object', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('public function hydrateObjects(string $className, iterable $payloads) : \EventSauce\ObjectHydrator\IterableList', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('public function serializeObject(object $object) : mixed', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('public function serializeObjects(iterable $payloads) : \EventSauce\ObjectHydrator\IterableList', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('public function getObjectMapperOperation🌀Root() : \ApiClients\Client\GitHub\Internal\Hydrator\Operation\Root', $files['Internal\Hydrators']->contents);
         self::assertStringContainsString('final class Hydrators implements \EventSauce\ObjectHydrator\ObjectMapper', $files['Internal\Hydrators']->contents);
 
+        self::assertStringNotContainsString('namespace \\', $files['Internal\Hydrator\Operation\Root']->contents);
         self::assertStringContainsString('public function hydrateObject(string $className, array $payload): object', $files['Internal\Hydrator\Operation\Root']->contents);
         self::assertStringContainsString('public function hydrateObjects(string $className, iterable $payloads): IterableList', $files['Internal\Hydrator\Operation\Root']->contents);
         self::assertStringContainsString('public function serializeObject(object $object): mixed', $files['Internal\Hydrator\Operation\Root']->contents);