Improve check_refs

Handle manual anchor. Return exit code.

Author: nikic

spec/07-variables.md

@@ -153,7 +153,7 @@ Since undefined local variables are not defined implicitly, they stay undefined.
 
 *byRef Context*
 
-If the undefined variable is used in a [byRef context](04-basic-concepts#byRef) then PHP defines the variable implicitly. Hence, a VSlot is created for it and `NULL` is stored in it. A notice is *not* emitted in such a case.
+If the undefined variable is used in a byRef context then PHP defines the variable implicitly. Hence, a VSlot is created for it and `NULL` is stored in it. A notice is *not* emitted in such a case.
 
 *Examples of Undefined Variables*
 

tools/check_refs.php

@@ -10,9 +10,18 @@
         $fullAnchor = $fileName . '#' . $info['anchor'];
         $anchors[$fullAnchor] = true;
     }
+
+    // Collect manual anchors as well
+    if (preg_match_all('/<a name="([^"]+)">/', $contents, $matches)) {
+        foreach ($matches[1] as $anchor) {
+            $fullAnchor = $fileName . '#' . $anchor;
+            $anchors[$fullAnchor] = true;
+        }
+    }
 }
 
 // Find unknown anchor references
+$foundUnknown = false;
 foreach (spec_files() as $fileName => $path) {
     $contents = file_get_contents($path);
 
@@ -33,7 +42,10 @@
         }
 
         if (!isset($anchors[$anchor])) {
+            $foundUnknown = true;
             echo "Unknown anchor $anchor in $fileName\n";
         }
     }
 }
+
+exit($foundUnknown ? 1 : 0);