Skip to content

Commit df1a90e

Browse files
committed
Update config options for real-time benchmark
Valgrind based instruction count is no longer available, but two debugging related options were recently added.
1 parent ce798af commit df1a90e

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

.github/workflows/real-time-benchmark.yml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,16 @@ on:
1616
options:
1717
- "0"
1818
- "1"
19-
instruction_count:
20-
description: 'Whether Valgrind instruction count should be measured'
19+
collect_extended_perf_stats:
20+
description: 'Whether to collect extended perf stats as artifacts'
21+
required: true
22+
default: "0"
23+
type: choice
24+
options:
25+
- "0"
26+
- "1"
27+
debug_environment:
28+
description: 'Whether to collect environment debug logs as artifacts'
2129
required: true
2230
default: "0"
2331
type: choice
@@ -50,7 +58,8 @@ jobs:
5058
BASELINE_COMMIT: "d5f6e56610c729710073350af318c4ea1b292cfe"
5159
ID: "master"
5260
JIT: "1"
53-
INSTRUCTION_COUNT: "0"
61+
COLLECT_EXTENDED_PERF_STATS: "0"
62+
DEBUG_ENVIRONMENT: "0"
5463
RUN_MICRO_BENCH: "0"
5564
YEAR: ""
5665
steps:
@@ -81,7 +90,8 @@ jobs:
8190
echo "ID=benchmarked" >> $GITHUB_ENV
8291
8392
echo "JIT=${{ inputs.jit }}" >> $GITHUB_ENV
84-
echo "INSTRUCTION_COUNT=${{ inputs.instruction_count }}" >> $GITHUB_ENV
93+
echo "COLLECT_EXTENDED_PERF_STATS=${{ inputs.collect_extended_perf_stats }}" >> $GITHUB_ENV
94+
echo "DEBUG_ENVIRONMENT=${{ inputs.debug_environment }}" >> $GITHUB_ENV
8595
echo "RUN_MICRO_BENCH=${{ inputs.run_micro_bench }}" >> $GITHUB_ENV
8696
fi
8797
@@ -250,7 +260,8 @@ jobs:
250260
cp ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini.dist ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
251261
sed -i "s|INFRA_DOCKER_REGISTRY=public.ecr.aws/abcdefgh|INFRA_DOCKER_REGISTRY=${{ secrets.PHP_VERSION_BENCHMARK_DOCKER_REGISTRY }}|g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
252262
sed -i "s|INFRA_WORKSPACE=|INFRA_WORKSPACE=$WORKSPACE|g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
253-
sed -i "s/INFRA_MEASURE_INSTRUCTION_COUNT=0/INFRA_MEASURE_INSTRUCTION_COUNT=${{ env.INSTRUCTION_COUNT }}/g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
263+
sed -i "s/INFRA_COLLECT_EXTENDED_PERF_STATS=0/INFRA_COLLECT_EXTENDED_PERF_STATS=${{ env.COLLECT_EXTENDED_PERF_STATS }}/g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
264+
sed -i "s/INFRA_DEBUG_ENVIRONMENT=0/INFRA_DEBUG_ENVIRONMENT=${{ env.DEBUG_ENVIRONMENT }}/g" ./php-version-benchmarks/config/infra/aws/x86_64-metal.ini
254265
255266
cp ./php-version-benchmarks/build/infrastructure/config/aws.tfvars.dist ./php-version-benchmarks/build/infrastructure/config/aws.tfvars
256267
sed -i 's/access_key = ""/access_key = "${{ secrets.PHP_VERSION_BENCHMARK_AWS_ACCESS_KEY }}"/g' ./php-version-benchmarks/build/infrastructure/config/aws.tfvars

0 commit comments

Comments
 (0)