Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious test failures in sapi/fpm on Travis CI #9770

Closed
TysonAndre opened this issue Oct 18, 2022 · 2 comments
Closed

Spurious test failures in sapi/fpm on Travis CI #9770

TysonAndre opened this issue Oct 18, 2022 · 2 comments

Comments

@TysonAndre
Copy link
Contributor

TysonAndre commented Oct 18, 2022

Description

https://app.travis-ci.com/github/php/php-src/jobs/585899735 failed spuriously with this output for #9768 and for #9757

The default port seems to be 7777 for sapi/fpm/tests/tester.inc - maybe another unit test called it on that port, or maybe the status is incorrectly reported. idle processes: 0 and 1 active process didn't match the expected output of 1 idle process and 0 active processes.

EDIT: Would adding a sleep/retry help? Or is the issue that processes remain active even after the http response is fully sent and the connection is closed? Not familiar with fpm's internals.

A --CONFLICTS-- section with other fpm tests using tester.inc may also help

=====================================================================
Spawning 16 workers... Done in 0.79s
=====================================================================
========DIFF========
001+ ERROR: Expected body does not match pattern
001- Done
002+ BODY:
003+ string(377) "pool:                 unconfined
004+ process manager:      static
005+ start time:           18/Oct/2022:02:38:56 +0000
006+ start since:          0
007+ accepted conn:        1
008+ listen queue:         0
009+ max listen queue:     0
010+ listen queue len:     4096
011+ idle processes:       0
012+ active processes:     1
013+ total processes:      1
014+ max active processes: 1
015+ max children reached: 0
016+ slow requests:        0"
017+ PATTERN:
018+ string(345) "(pool:\s+unconfined
019+ process manager:\s+static
020+ start time:\s+\d+\/\w{3}\/\d{4}:\d{2}:\d{2}:\d{2}\s[+-]\d{4}
021+ start since:\s+\d+
022+ accepted conn:\s+\d+
023+ listen queue:\s+0
024+ max listen queue:\s+0
025+ listen queue len:\s+\d+
026+ idle processes:\s+1
027+ active processes:\s+0
028+ total processes:\s+1
029+ max active processes:\s+1
030+ max children reached:\s+0
031+ slow requests:\s+0)"
032+ Done
========DONE========
FAIL FPM: Status listen test [sapi/fpm/tests/status-listen.phpt] 
=====================================================================

PHP Version

PHP 8.3 (any?)

Operating System

No response

@TysonAndre
Copy link
Contributor Author

TysonAndre commented Oct 24, 2022

7407589 7407589 @bukka @nikic thoughts on restoring that commit for idle_processes/active_processes, or ideas of what the underlying issue could be?

Has a tcp port conflict been ruled out?

it seems to reoccur on arm64 (I haven't checked if that's all builds or just the one)

ENABLE_ZTS=1 ENABLE_DEBUG=1 ARM64=1

@bukka
Copy link
Member

bukka commented Oct 30, 2022

I added some delay as it's likely not enough time for Travis to switch most likely due resources. We can of course re-open this if it doesn't help and I will try to either extend delay or just not check idle and active...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants