Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

Commit 5aa58fe

Browse files
committed
Move duplicated clientCapabilities() to AbstractExtension
1 parent 06b3755 commit 5aa58fe

File tree

6 files changed

+24
-30
lines changed

6 files changed

+24
-30
lines changed

lib/AbstractExtension.php

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?php
2+
3+
namespace Phpactor\Extension;
4+
5+
use Phpactor\Container\Container;
6+
use Phpactor\LanguageServerProtocol\ClientCapabilities;
7+
8+
abstract class AbstractExtension
9+
{
10+
protected function clientCapabilities(Container $container): ClientCapabilities
11+
{
12+
return $container->get(ClientCapabilities::class);
13+
}
14+
}

lib/LanguageServerCompletion/LanguageServerCompletionExtension.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Phpactor\Container\Container;
66
use Phpactor\Container\ContainerBuilder;
77
use Phpactor\Container\Extension;
8+
use Phpactor\Extension\AbstractExtension;
89
use Phpactor\Extension\Completion\CompletionExtension;
910
use Phpactor\Extension\LanguageServerCodeTransform\Model\NameImport\NameImporter;
1011
use Phpactor\Extension\LanguageServerCompletion\Handler\SignatureHelpHandler;
@@ -14,7 +15,7 @@
1415
use Phpactor\LanguageServerProtocol\ClientCapabilities;
1516
use Phpactor\MapResolver\Resolver;
1617

17-
class LanguageServerCompletionExtension implements Extension
18+
class LanguageServerCompletionExtension extends AbstractExtension implements Extension
1819
{
1920
private const PARAM_TRIM_LEADING_DOLLAR = 'language_server_completion.trim_leading_dollar';
2021

@@ -67,9 +68,4 @@ private function registerHandlers(ContainerBuilder $container): void
6768
);
6869
}, [ LanguageServerExtension::TAG_METHOD_HANDLER => [] ]);
6970
}
70-
71-
private function clientCapabilities(Container $container): ClientCapabilities
72-
{
73-
return $container->get(ClientCapabilities::class);
74-
}
7571
}

lib/LanguageServerHover/LanguageServerHoverExtension.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Phpactor\CodeBuilder\Domain\TemplatePathResolver\PhpVersionPathResolver;
66
use Phpactor\Container\Container;
77
use Phpactor\Container\ContainerBuilder;
8+
use Phpactor\Extension\AbstractExtension;
89
use Phpactor\Extension\Logger\LoggingExtension;
910
use Phpactor\Extension\Php\Model\PhpVersionResolver;
1011
use Phpactor\Extension\WorseReflection\WorseReflectionExtension;
@@ -16,7 +17,7 @@
1617
use Phpactor\Container\Extension;
1718
use Phpactor\MapResolver\Resolver;
1819

19-
class LanguageServerHoverExtension implements Extension
20+
class LanguageServerHoverExtension extends AbstractExtension implements Extension
2021
{
2122
public const PARAM_TEMPLATE_PATHS = 'language_server_hover.template_paths';
2223

@@ -77,9 +78,4 @@ public function load(ContainerBuilder $container): void
7778
return $builder->build();
7879
});
7980
}
80-
81-
private function clientCapabilities(Container $container): ClientCapabilities
82-
{
83-
return $container->get(ClientCapabilities::class);
84-
}
8581
}

lib/LanguageServerIndexer/LanguageServerIndexerExtension.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Phpactor\Container\Container;
77
use Phpactor\Container\ContainerBuilder;
88
use Phpactor\Container\Extension;
9+
use Phpactor\Extension\AbstractExtension;
910
use Phpactor\Extension\LanguageServerIndexer\Handler\IndexerHandler;
1011
use Phpactor\Extension\LanguageServerIndexer\Handler\WorkspaceSymbolHandler;
1112
use Phpactor\Extension\LanguageServerIndexer\Listener\ReindexListener;
@@ -23,7 +24,7 @@
2324
use Phpactor\TextDocument\TextDocumentLocator;
2425
use Psr\EventDispatcher\EventDispatcherInterface;
2526

26-
class LanguageServerIndexerExtension implements Extension
27+
class LanguageServerIndexerExtension extends AbstractExtension implements Extension
2728
{
2829
public const WORKSPACE_SYMBOL_SEARCH_LIMIT = 'language_server_indexer.workspace_symbol_search_limit';
2930

@@ -85,9 +86,4 @@ private function registerSessionHandler(ContainerBuilder $container): void
8586
LanguageServerExtension::TAG_LISTENER_PROVIDER => [],
8687
]);
8788
}
88-
89-
private function clientCapabilities(Container $container): ClientCapabilities
90-
{
91-
return $container->get(ClientCapabilities::class);
92-
}
9389
}

lib/LanguageServerReferenceFinder/LanguageServerReferenceFinderExtension.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Phpactor\Container\Container;
77
use Phpactor\Container\ContainerBuilder;
88
use Phpactor\Container\Extension;
9+
use Phpactor\Extension\AbstractExtension;
910
use Phpactor\Extension\LanguageServerBridge\Converter\LocationConverter;
1011
use Phpactor\Extension\LanguageServerReferenceFinder\Handler\GotoDefinitionHandler;
1112
use Phpactor\Extension\LanguageServerReferenceFinder\Handler\GotoImplementationHandler;
@@ -22,7 +23,7 @@
2223
use Phpactor\MapResolver\Resolver;
2324
use Phpactor\ReferenceFinder\ReferenceFinder;
2425

25-
class LanguageServerReferenceFinderExtension implements Extension
26+
class LanguageServerReferenceFinderExtension extends AbstractExtension implements Extension
2627
{
2728
const PARAM_REFERENCE_TIMEOUT = 'language_server_reference_reference_finder.reference_timeout';
2829

@@ -99,9 +100,4 @@ public function configure(Resolver $schema): void
99100
self::PARAM_REFERENCE_TIMEOUT => 'Stop searching for references after this time (in seconds) has expired',
100101
]);
101102
}
102-
103-
private function clientCapabilities(Container $container): ClientCapabilities
104-
{
105-
return $container->get(ClientCapabilities::class);
106-
}
107103
}

lib/LanguageServerSymbolProvider/LanguageServerSymbolProviderExtension.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@
66
use Phpactor\Container\Container;
77
use Phpactor\Container\ContainerBuilder;
88
use Phpactor\Container\Extension;
9+
use Phpactor\Extension\AbstractExtension;
910
use Phpactor\Extension\LanguageServerSymbolProvider\Adapter\TolerantDocumentSymbolProvider;
1011
use Phpactor\Extension\LanguageServerSymbolProvider\Handler\DocumentSymbolProviderHandler;
1112
use Phpactor\Extension\LanguageServerSymbolProvider\Model\DocumentSymbolProvider;
1213
use Phpactor\Extension\LanguageServer\LanguageServerExtension;
1314
use Phpactor\LanguageServerProtocol\ClientCapabilities;
1415
use Phpactor\MapResolver\Resolver;
1516

16-
class LanguageServerSymbolProviderExtension implements Extension
17+
class LanguageServerSymbolProviderExtension extends AbstractExtension implements Extension
1718
{
1819
/**
1920
* {@inheritDoc}
@@ -40,9 +41,4 @@ public function load(ContainerBuilder $container): void
4041
public function configure(Resolver $schema): void
4142
{
4243
}
43-
44-
private function clientCapabilities(Container $container): ClientCapabilities
45-
{
46-
return $container->get(ClientCapabilities::class);
47-
}
4844
}

0 commit comments

Comments
 (0)