From 45b92887e04895d171c87e44110b849803ec47d5 Mon Sep 17 00:00:00 2001 From: Daniel Leech Date: Sun, 27 Dec 2020 09:24:11 +0000 Subject: [PATCH] Fix hover on namespaced function --- lib/LanguageServerHover/Handler/HoverHandler.php | 2 +- .../Unit/Handler/HoverHandlerTest.php | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/LanguageServerHover/Handler/HoverHandler.php b/lib/LanguageServerHover/Handler/HoverHandler.php index 3c55239b..502de936 100644 --- a/lib/LanguageServerHover/Handler/HoverHandler.php +++ b/lib/LanguageServerHover/Handler/HoverHandler.php @@ -175,7 +175,7 @@ private function renderMember(SymbolContext $symbolContext): string private function renderFunction(SymbolContext $symbolContext): string { - $name = $symbolContext->symbol()->name(); + $name = $symbolContext->name(); $function = $this->reflector->reflectFunction($name); return $this->renderer->render(new HoverInformation($name, $function->docblock()->formatted(), $function)); diff --git a/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php b/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php index daa3490b..92e790ab 100644 --- a/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php +++ b/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php @@ -16,7 +16,7 @@ class HoverHandlerTest extends IntegrationTestCase /** * @dataProvider provideHover */ - public function testHover(string $test) + public function testHover(string $test): void { [ $text, $offset ] = ExtractOffset::fromSource($test); @@ -82,7 +82,14 @@ private function f<>oo():string {} yield 'class' => [ 'ass A { } }', - 'A' + ]; + + yield 'function' => [ + 'oo();', + ]; + + yield 'namespaced function' => [ + 'oo();', ]; } }