Fix hardcoded PHP

Author: iMattPro

config/services.yml

@@ -21,6 +21,7 @@ services:
             - '@user'
             - '@notification_manager'
             - '%core.root_path%'
+            - '%core.php_ext%'
         tags:
             - { name: event.listener }
 

event/listener.php

@@ -53,6 +53,9 @@ class listener implements EventSubscriberInterface
 	/** @var string */
 	protected $root_path;
 
+	/** @var string */
+	protected $php_ext;
+
 	/**
 	 * Constructor
 	 *
@@ -65,8 +68,9 @@ class listener implements EventSubscriberInterface
 	 * @param user $user
 	 * @param manager $phpbb_notifications Notifications manager object
 	 * @param string $root_path
+	 * @param string $php_ext
 	 */
-	public function __construct(config $config, controller_helper $controller_helper, FastImageSize $imagesize, form_helper $form_helper, language $language, template $template, user $user, manager $phpbb_notifications, $root_path)
+	public function __construct(config $config, controller_helper $controller_helper, FastImageSize $imagesize, form_helper $form_helper, language $language, template $template, user $user, manager $phpbb_notifications, $root_path, $php_ext)
 	{
 		$this->config = $config;
 		$this->controller_helper = $controller_helper;
@@ -77,6 +81,7 @@ public function __construct(config $config, controller_helper $controller_helper
 		$this->user = $user;
 		$this->phpbb_notifications = $phpbb_notifications;
 		$this->root_path = $root_path;
+		$this->php_ext = $php_ext;
 	}
 
 	public static function getSubscribedEvents()
@@ -143,7 +148,7 @@ public function compatibility_notice()
 	public function pwa_manifest()
 	{
 		$this->template->assign_vars([
-			'U_MANIFEST_URL'	=> 'ext/phpbb/webpushnotifications/manifest.php',
+			'U_MANIFEST_URL'	=> 'ext/phpbb/webpushnotifications/manifest.' . $this->php_ext,
 			'U_TOUCH_ICON'		=> $this->config['pwa_icon_small'] ? ext::PWA_ICON_DIR . '/' . $this->config['pwa_icon_small'] : null,
 			'SHORT_SITE_NAME'	=> $this->config['pwa_short_name'] ?: $this->trim_shortname($this->config['sitename']),
 		]);

tests/event/listener_test.php

@@ -43,6 +43,9 @@ class listener_test extends \phpbb_database_test_case
 	/** @var string */
 	protected $root_path;
 
+	/** @var string */
+	protected $php_ext;
+
 	protected static function setup_extensions()
 	{
 		return ['phpbb/webpushnotifications'];
@@ -121,6 +124,7 @@ protected function setUp(): void
 		);
 
 		$this->root_path = $phpbb_root_path;
+		$this->php_ext = $phpEx;
 	}
 
 	protected function set_listener()
@@ -134,7 +138,8 @@ protected function set_listener()
 			$this->template,
 			$this->user,
 			$this->notifications,
-			$this->root_path
+			$this->root_path,
+			$this->php_ext
 		);
 	}