Add migration unit test.

Author: rxu

migrations/handle_subscriptions.php

@@ -10,9 +10,9 @@
 
 namespace phpbb\webpushnotifications\migrations;
 
-use phpbb\db\migration\container_aware_migration;
+use phpbb\db\migration\migration;
 
-class handle_subscriptions extends container_aware_migration
+class handle_subscriptions extends migration
 {
 	public function effectively_installed()
 	{
@@ -24,7 +24,7 @@ public function revert_data(): array
 		return [
 			['custom', [[$this, 'update_subscriptions']]],
 			['if', [
-				($this->container->has('notification.method.webpush')),
+				($this->db_tools->sql_table_exists($this->table_prefix . 'notification_push')),
 				['custom', [[$this, 'copy_subscription_tables']]],
 			]],
 			['if', [
@@ -47,7 +47,7 @@ public function update_subscriptions()
 		$user_notifications_table = $this->table_prefix . 'user_notifications';
 
 		// Check if webpush notification method exists in phpBB core (as of phpBB 4.0)
-		$core_webpush_exists = $this->container->has('notification.method.webpush');
+		$core_webpush_exists = $this->db_tools->sql_table_exists($this->table_prefix . 'notification_push');
 
 		/*
 		 * If webpush notification method exists in phpBB core,

tests/notification/fixtures/webpush_notification.type.post.xml

@@ -283,4 +283,9 @@
 			<value>1</value>
 		</row>
 	</table>
+	<table name="phpbb_config">
+		<column>config_name</column>
+		<column>config_value</column>
+		<column>is_dynamic</column>
+	</table>
 </dataset>

tests/notification/notification_method_webpush_test.php

@@ -91,9 +91,6 @@ protected function setUp(): void
 
 		global $db, $config, $user, $auth, $cache, $phpbb_container, $phpbb_dispatcher;
 
-//		$avatar_helper = $this->getMockBuilder('\phpbb\avatar\helper')
-//			->disableOriginalConstructor()
-//			->getMock();
 		$db = $this->db = $this->new_dbal();
 		$config = $this->config = new \phpbb\config\config([
 			'allow_privmsg'			=> true,
@@ -438,4 +435,97 @@ protected function get_messages_for_subscription($client_hash): array
 
 		return $response_data['data']['messages'];
 	}
+
+	/**
+	 * @depends test_get_subscription
+	 */
+	public function test_export_data_with_migration(): void
+	{
+		global $phpbb_root_path, $phpEx;
+
+		require_once __DIR__ . '/../../migrations/handle_subscriptions.php'; // load the extension migration
+
+		$this->config['wpn_webpush_enable'] = '1';
+		$this->config['webpush_enable'] = '';
+		$this->config['webpush_vapid_public'] = '';
+		$this->config['webpush_vapid_private'] = '';
+
+		$config_db = new \phpbb\config\db($this->container->get('dbal.conn'), $this->container->get('cache.driver'), 'phpbb_config');
+		foreach ($this->config as $config_name => $config_value)
+		{
+			$config_db->set($config_name, $config_value);
+		}
+
+		$factory = new \phpbb\db\tools\factory();
+		$db_tools = $factory->get($this->db);
+
+		$phpbb_notification_push_data = [
+			'COLUMNS'	=> [
+				'notification_type_id'	=> ['USINT', 0],
+				'item_id'				=> ['ULINT', 0],
+				'item_parent_id'		=> ['ULINT', 0],
+				'user_id'				=> ['ULINT', 0],
+				'push_data'				=> ['MTEXT', ''],
+				'notification_time'		=> ['TIMESTAMP', 0]
+			],
+			'PRIMARY_KEY' => ['notification_type_id', 'item_id', 'item_parent_id', 'user_id'],
+		];
+		$db_tools->sql_create_table('phpbb_notification_push', $phpbb_notification_push_data);
+
+		$phpbb_push_subscriptions_data = [
+			'COLUMNS'	=> [
+				'subscription_id'	=> ['ULINT', null, 'auto_increment'],
+				'user_id'			=> ['ULINT', 0],
+				'endpoint'			=> ['TEXT', ''],
+				'expiration_time'	=> ['TIMESTAMP', 0],
+				'p256dh'			=> ['VCHAR', ''],
+				'auth'				=> ['VCHAR', ''],
+			],
+			'PRIMARY_KEY' => ['subscription_id', 'user_id'],
+		];
+		$db_tools->sql_create_table('phpbb_push_subscriptions', $phpbb_push_subscriptions_data);
+
+		$config_tool = new \phpbb\db\migration\tool\config($config_db);
+		$this->container->set('migrator.tool.config', $config_tool);
+		$tools_collection = new \phpbb\di\service_collection($this->container);
+		$tools_collection->add('migrator.tool.config');
+
+		$migrator = new \phpbb\db\migrator(
+			$this->container,
+			$config_db,
+			$this->db,
+			$db_tools,
+			'phpbb_migrations',
+			$phpbb_root_path,
+			$phpEx,
+			'phpbb_',
+			$tools_collection,
+			new \phpbb\db\migration\helper()
+		);
+		$migrator->create_migrations_table();
+
+		$migration_class = '\phpbb\webpushnotifications\migrations\handle_subscriptions';
+		$migrator->populate_migrations([$migration_class]);
+
+		while ($migrator->migration_state($migration_class) !== false)
+		{
+			$migrator->revert($migration_class);
+		}
+
+		$sql = 'SELECT config_name, config_value FROM ' . CONFIG_TABLE . "
+			WHERE config_name IN('webpush_enable', 'webpush_vapid_public', 'webpush_vapid_private')";
+		$result = $this->db->sql_query($sql);
+		$data = $this->db->sql_fetchrowset($result);
+		$this->db->sql_freeresult($result);
+
+		$exported_config_data = [];
+		foreach ($data as $row)
+		{
+			$exported_config_data[$row['config_name']] = $row['config_value'];
+		}
+
+		$this->assertEquals($this->config['wpn_webpush_enable'], $exported_config_data['webpush_enable']);
+		$this->assertEquals($this->config['wpn_webpush_vapid_public'], $exported_config_data['webpush_vapid_public']);
+		$this->assertEquals($this->config['wpn_webpush_vapid_private'], $exported_config_data['webpush_vapid_private']);
+	}
 }