Refactor trim method for readability

iMattPro · iMattPro · commit dd44ba1483b0 · 2024-12-05T08:10:02.000-08:00
diff --git a/event/listener.php b/event/listener.php
@@ -366,6 +366,8 @@ protected function can_use_notifications()
 	 */
 	protected function trim_shortname($name)
 	{
-		return htmlspecialchars(utf8_substr(ext::decode_entities($name, ENT_QUOTES), 0, 12), ENT_QUOTES, 'UTF-8');
+		$decoded = ext::decode_entities($name, ENT_QUOTES);
+		$trimmed = utf8_substr($decoded, 0, 12);
+		return htmlspecialchars($trimmed, ENT_QUOTES, 'UTF-8');
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -366,6 +366,8 @@ protected function can_use_notifications()`
`366`	`366`	`*/`
`367`	`367`	`protected function trim_shortname($name)`
`368`	`368`	`{`
`369`		`- return htmlspecialchars(utf8_substr(ext::decode_entities($name, ENT_QUOTES), 0, 12), ENT_QUOTES, 'UTF-8');`
	`369`	`+ $decoded = ext::decode_entities($name, ENT_QUOTES);`
	`370`	`+ $trimmed = utf8_substr($decoded, 0, 12);`
	`371`	`+ return htmlspecialchars($trimmed, ENT_QUOTES, 'UTF-8');`
`370`	`372`	`}`
`371`	`373`	`}`