String primary keys should not be type checked

Author: phpfui

Tests/Unit/MiscellaneousTest.php

@@ -4,14 +4,6 @@
 
 class MiscellaneousTest extends \PHPUnit\Framework\TestCase
 	{
-	public function testNoStringPrimaryKey() : void
-		{
-		$customer = new \Tests\App\Record\Customer(1);
-		$this->assertTrue($customer->loaded());
-		$this->expectException(\PHPFUI\ORM\Exception::class);
-		$customer = new \Tests\App\Record\Customer('test');
-		}
-
 	public function testRow() : void
 		{
 		$row = \PHPFUI\ORM::getRow('select * from customer');

src/PHPFUI/ORM/Record.php

@@ -63,18 +63,28 @@ public function __construct(int|array|null|string $parameter = null)
 
 		switch ($type)
 		  {
-			case 'integer':
-				$type = 'int';
-				// Intentionally fall through
 			case 'string':
 
-				if (1 == \count(static::$primaryKeys) && $type == static::$fields[static::$primaryKeys[0]][self::PHP_TYPE_INDEX])
+				if (1 == \count(static::$primaryKeys))
+					{
+					$this->read($parameter);
+					}
+				else
+					{
+					throw new \PHPFUI\ORM\Exception(static::class . ' has no string primary key');
+					}
+
+				break;
+
+			case 'integer':
+
+				if (1 == \count(static::$primaryKeys) && 'int' == static::$fields[static::$primaryKeys[0]][self::PHP_TYPE_INDEX])
 					{
 					$this->read($parameter);
 					}
 				else
 					{
-					throw new \PHPFUI\ORM\Exception(static::class . ' has no ' . $type . ' primary key');
+					throw new \PHPFUI\ORM\Exception(static::class . ' does not have an integer primary key');
 					}
 
 				break;