Fix off by one in saving multipoints

nijel · nijel · commit 2a7e460c2f19 · 2016-06-24T18:41:04.000+02:00
Signed-off-by: Michal Čihař &lt;michal@cihar.com&gt;
diff --git a/src/ShapeRecord.php b/src/ShapeRecord.php
@@ -334,7 +334,7 @@ private function _saveMultiPointRecord() {
 
         fwrite($this->SHPFile, pack('V', $this->SHPData['numpoints']));
 
-        for ($i = 0; $i <= $this->SHPData['numpoints']; $i++) {
+        for ($i = 0; $i < $this->SHPData['numpoints']; $i++) {
             $this->_savePoint($this->SHPData['points'][$i]);
         }
     }
@@ -346,7 +346,7 @@ private function _saveMultiPointMZRecord($type) {
 
         fwrite($this->SHPFile, pack('dd', $this->SHPData[$type.'min'], $this->SHPData[$type.'max']));
 
-        for ($i = 0; $i <= $this->SHPData['numpoints']; $i++) {
+        for ($i = 0; $i < $this->SHPData['numpoints']; $i++) {
             fwrite($this->SHPFile, Util::packDouble($this->SHPData['points'][$type]));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ private function _saveMultiPointRecord() {`
`334`	`334`
`335`	`335`	`fwrite($this->SHPFile, pack('V', $this->SHPData['numpoints']));`
`336`	`336`
`337`		`- for ($i = 0; $i <= $this->SHPData['numpoints']; $i++) {`
	`337`	`+ for ($i = 0; $i < $this->SHPData['numpoints']; $i++) {`
`338`	`338`	`$this->_savePoint($this->SHPData['points'][$i]);`
`339`	`339`	`}`
`340`	`340`	`}`
`@@ -346,7 +346,7 @@ private function _saveMultiPointMZRecord($type) {`
`346`	`346`
`347`	`347`	`fwrite($this->SHPFile, pack('dd', $this->SHPData[$type.'min'], $this->SHPData[$type.'max']));`
`348`	`348`
`349`		`- for ($i = 0; $i <= $this->SHPData['numpoints']; $i++) {`
	`349`	`+ for ($i = 0; $i < $this->SHPData['numpoints']; $i++) {`
`350`	`350`	`fwrite($this->SHPFile, Util::packDouble($this->SHPData['points'][$type]));`
`351`	`351`	`}`
`352`	`352`	`}`