Fix a condition in addRecord to be more accurate with the documented type

williamdes · williamdes · commit f1d82f04030f · 2023-06-29T18:36:54.000+02:00
Signed-off-by: William Desportes &lt;williamdes@wdes.fr&gt;
diff --git a/src/ShapeFile.php b/src/ShapeFile.php
@@ -231,7 +231,7 @@ private function updateBBox(string $type, array $data): void
      */
     public function addRecord(ShapeRecord $record): int
     {
-        if (isset($this->dbfHeader) && (is_array($this->dbfHeader))) {
+        if ($this->dbfHeader !== null) {
             $record->updateDBFInfo($this->dbfHeader);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ private function updateBBox(string $type, array $data): void`
`231`	`231`	`*/`
`232`	`232`	`public function addRecord(ShapeRecord $record): int`
`233`	`233`	`{`
`234`		`- if (isset($this->dbfHeader) && (is_array($this->dbfHeader))) {`
	`234`	`+ if ($this->dbfHeader !== null) {`
`235`	`235`	`$record->updateDBFInfo($this->dbfHeader);`
`236`	`236`	`}`
`237`	`237`