Run entity mapping rules without objectManagerLoader only on bleedingEdge

Author: ondrejmirtes

rules.neon

@@ -38,6 +38,7 @@ services:
 		arguments:
 			reportUnknownTypes: %doctrine.reportUnknownTypes%
 			allowNullablePropertyForRequiredField: %doctrine.allowNullablePropertyForRequiredField%
+			bleedingEdge: %featureToggles.bleedingEdge%
 		tags:
 			- phpstan.rules.rule
 	-
@@ -48,5 +49,6 @@ services:
 		class: PHPStan\Rules\Doctrine\ORM\EntityRelationRule
 		arguments:
 			allowNullablePropertyForRequiredField: %doctrine.allowNullablePropertyForRequiredField%
+			bleedingEdge: %featureToggles.bleedingEdge%
 		tags:
 			- phpstan.rules.rule

src/Rules/Doctrine/ORM/EntityColumnRule.php

@@ -45,19 +45,24 @@ class EntityColumnRule implements Rule
 	/** @var bool */
 	private $allowNullablePropertyForRequiredField;
 
+	/** @var bool */
+	private $bleedingEdge;
+
 	public function __construct(
 		ObjectMetadataResolver $objectMetadataResolver,
 		DescriptorRegistry $descriptorRegistry,
 		ReflectionProvider $reflectionProvider,
 		bool $reportUnknownTypes,
-		bool $allowNullablePropertyForRequiredField
+		bool $allowNullablePropertyForRequiredField,
+		bool $bleedingEdge
 	)
 	{
 		$this->objectMetadataResolver = $objectMetadataResolver;
 		$this->descriptorRegistry = $descriptorRegistry;
 		$this->reflectionProvider = $reflectionProvider;
 		$this->reportUnknownTypes = $reportUnknownTypes;
 		$this->allowNullablePropertyForRequiredField = $allowNullablePropertyForRequiredField;
+		$this->bleedingEdge = $bleedingEdge;
 	}
 
 	public function getNodeType(): string
@@ -67,6 +72,9 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		if (!$this->bleedingEdge && !$this->objectMetadataResolver->hasObjectManagerLoader()) {
+			return [];
+		}
 		$class = $scope->getClassReflection();
 		if ($class === null) {
 			return [];

src/Rules/Doctrine/ORM/EntityRelationRule.php

@@ -28,13 +28,18 @@ class EntityRelationRule implements Rule
 	/** @var bool */
 	private $allowNullablePropertyForRequiredField;
 
+	/** @var bool */
+	private $bleedingEdge;
+
 	public function __construct(
 		ObjectMetadataResolver $objectMetadataResolver,
-		bool $allowNullablePropertyForRequiredField
+		bool $allowNullablePropertyForRequiredField,
+		bool $bleedingEdge
 	)
 	{
 		$this->objectMetadataResolver = $objectMetadataResolver;
 		$this->allowNullablePropertyForRequiredField = $allowNullablePropertyForRequiredField;
+		$this->bleedingEdge = $bleedingEdge;
 	}
 
 	public function getNodeType(): string
@@ -44,6 +49,10 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		if (!$this->bleedingEdge && !$this->objectMetadataResolver->hasObjectManagerLoader()) {
+			return [];
+		}
+
 		$class = $scope->getClassReflection();
 		if ($class === null) {
 			return [];

src/Type/Doctrine/ObjectMetadataResolver.php

@@ -42,6 +42,11 @@ public function __construct(
 		$this->repositoryClass = $repositoryClass;
 	}
 
+	public function hasObjectManagerLoader(): bool
+	{
+		return $this->objectManagerLoader !== null;
+	}
+
 	/** @api */
 	public function getObjectManager(): ?ObjectManager
 	{

tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php

@@ -76,7 +76,8 @@ protected function getRule(): Rule
 			]),
 			$this->createReflectionProvider(),
 			true,
-			$this->allowNullablePropertyForRequiredField
+			$this->allowNullablePropertyForRequiredField,
+			true
 		);
 	}
 

tests/Rules/Doctrine/ORM/EntityRelationRuleTest.php

@@ -23,7 +23,8 @@ protected function getRule(): Rule
 	{
 		return new EntityRelationRule(
 			new ObjectMetadataResolver($this->createReflectionProvider(), $this->objectManagerLoader, null),
-			$this->allowNullablePropertyForRequiredField
+			$this->allowNullablePropertyForRequiredField,
+			true
 		);
 	}