[BCB] Remove options that existed only for performance reasons

Author: ondrejmirtes

Diff for: extension.neon

@@ -9,8 +9,6 @@ parameters:
 		queryBuilderClass: null
 		allCollectionsSelectable: true
 		objectManagerLoader: null
-		searchOtherMethodsForQueryBuilderBeginning: true
-		queryBuilderFastAlgorithm: false
 		literalString: false
 	featureToggles:
 		skipCheckGenericClasses:
@@ -79,8 +77,6 @@ parametersSchema:
 		queryBuilderClass: schema(string(), nullable())
 		allCollectionsSelectable: bool()
 		objectManagerLoader: schema(string(), nullable())
-		searchOtherMethodsForQueryBuilderBeginning: bool()
-		queryBuilderFastAlgorithm: bool()
 		reportDynamicQueryBuilders: bool()
 		reportUnknownTypes: bool()
 		allowNullablePropertyForRequiredField: bool()
@@ -117,7 +113,6 @@ services:
 		class: PHPStan\Type\Doctrine\QueryBuilder\CreateQueryBuilderDynamicReturnTypeExtension
 		arguments:
 			queryBuilderClass: %doctrine.queryBuilderClass%
-			fasterVersion: %doctrine.queryBuilderFastAlgorithm%
 		tags:
 			- phpstan.broker.dynamicMethodReturnTypeExtension
 	-
@@ -194,7 +189,6 @@ services:
 	-
 		class: PHPStan\Type\Doctrine\QueryBuilder\OtherMethodQueryBuilderParser
 		arguments:
-			descendIntoOtherMethods: %doctrine.searchOtherMethodsForQueryBuilderBeginning%
 			parser: @defaultAnalysisParser
 
 	-

Diff for: rules.neon

@@ -12,8 +12,6 @@ parametersSchema:
 		queryBuilderClass: schema(string(), nullable())
 		allCollectionsSelectable: bool()
 		objectManagerLoader: schema(string(), nullable())
-		searchOtherMethodsForQueryBuilderBeginning: bool()
-		queryBuilderFastAlgorithm: bool()
 		reportDynamicQueryBuilders: bool()
 		reportUnknownTypes: bool()
 		allowNullablePropertyForRequiredField: bool()

Diff for: src/Type/Doctrine/QueryBuilder/CreateQueryBuilderDynamicReturnTypeExtension.php

@@ -13,15 +13,11 @@ class CreateQueryBuilderDynamicReturnTypeExtension implements DynamicMethodRetur
 
 	private ?string $queryBuilderClass = null;
 
-	private bool $fasterVersion;
-
 	public function __construct(
-		?string $queryBuilderClass,
-		bool $fasterVersion
+		?string $queryBuilderClass
 	)
 	{
 		$this->queryBuilderClass = $queryBuilderClass;
-		$this->fasterVersion = $fasterVersion;
 	}
 
 	public function getClass(): string
@@ -40,12 +36,7 @@ public function getTypeFromMethodCall(
 		Scope $scope
 	): Type
 	{
-		$class = SimpleQueryBuilderType::class;
-		if (!$this->fasterVersion) {
-			$class = BranchingQueryBuilderType::class;
-		}
-
-		return new $class(
+		return new BranchingQueryBuilderType(
 			$this->queryBuilderClass ?? 'Doctrine\ORM\QueryBuilder',
 		);
 	}

Diff for: src/Type/Doctrine/QueryBuilder/OtherMethodQueryBuilderParser.php

@@ -28,8 +28,6 @@
 class OtherMethodQueryBuilderParser
 {
 
-	private bool $descendIntoOtherMethods;
-
 	private Parser $parser;
 
 	private Container $container;
@@ -41,9 +39,8 @@ class OtherMethodQueryBuilderParser
 	 */
 	private array $cache = [];
 
-	public function __construct(bool $descendIntoOtherMethods, Parser $parser, Container $container)
+	public function __construct(Parser $parser, Container $container)
 	{
-		$this->descendIntoOtherMethods = $descendIntoOtherMethods;
 		$this->parser = $parser;
 		$this->container = $container;
 	}
@@ -53,10 +50,6 @@ public function __construct(bool $descendIntoOtherMethods, Parser $parser, Conta
 	 */
 	public function findQueryBuilderTypesInCalledMethod(Scope $scope, MethodReflection $methodReflection): array
 	{
-		if (!$this->descendIntoOtherMethods) {
-			return [];
-		}
-
 		$methodName = $methodReflection->getName();
 		$className = $methodReflection->getDeclaringClass()->getName();
 		$fileName = $methodReflection->getDeclaringClass()->getFileName();