Skip to content

Commit 6ec9016

Browse files
committed
Add error identifiers
1 parent ea07b96 commit 6ec9016

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Diff for: src/Rule/Nette/DoNotExtendNetteObjectRule.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function processNode(Node $node, Scope $scope): array
3535
$classReflection->getDisplayName(),
3636
'Nette\Object',
3737
'Nette\SmartObject'
38-
))->build(),
38+
))->identifier('class.extendsNetteObject')->build(),
3939
];
4040
}
4141

Diff for: src/Rule/Nette/RegularExpressionPatternRule.php

+3-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ public function processNode(Node $node, Scope $scope): array
3535
continue;
3636
}
3737

38-
$errors[] = RuleErrorBuilder::message(sprintf('Regex pattern is invalid: %s', $errorMessage))->build();
38+
$errors[] = RuleErrorBuilder::message(sprintf('Regex pattern is invalid: %s', $errorMessage))
39+
->identifier('regexp.pattern')
40+
->build();
3941
}
4042

4143
return $errors;

Diff for: src/Rule/Nette/RethrowExceptionRule.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
use PhpParser\Node\Stmt\TryCatch;
99
use PHPStan\Analyser\Scope;
1010
use PHPStan\Rules\Rule;
11+
use PHPStan\Rules\RuleErrorBuilder;
1112
use PHPStan\Type\ObjectType;
1213
use PHPStan\Type\TypeCombinator;
1314
use Throwable;
@@ -86,7 +87,7 @@ public function processNode(Node $node, Scope $scope): array
8687
}
8788
}
8889

89-
$messages[] = sprintf('Exception %s needs to be rethrown.', $exceptionName);
90+
$messages[] = RuleErrorBuilder::message(sprintf('Exception %s needs to be rethrown.', $exceptionName))->identifier('nette.rethrowException')->build();
9091
}
9192

9293
return $messages;

0 commit comments

Comments
 (0)