Skip to content

Commit 3ecbd3c

Browse files
committed
Fix error message for "assertNotEquals" usage referencing "assertSame" and "assertEquals"
1 parent e32ac65 commit 3ecbd3c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php

+8
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,14 @@ public function processNode(Node $node, Scope $scope): array
5555
&& ($leftType->isSuperTypeOf($rightType)->yes())
5656
&& ($rightType->isSuperTypeOf($leftType)->yes())
5757
) {
58+
if (strtolower($node->name->name) === 'assertnotequals') {
59+
return [
60+
RuleErrorBuilder::message(
61+
'You should use assertNotSame() instead of assertNotEquals(), because both values are scalars of the same type',
62+
)->identifier('phpunit.assertEquals')->build(),
63+
];
64+
}
65+
5866
return [
5967
RuleErrorBuilder::message(
6068
'You should use assertSame() instead of assertEquals(), because both values are scalars of the same type',

0 commit comments

Comments
 (0)