Skip to content

Commit ce84290

Browse files
committed
Use sprintf instead of new branch to return correct error message
1 parent 1a7f3e1 commit ce84290

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

Diff for: src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php

+6-9
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use PHPStan\Type\TypeCombinator;
1212
use function count;
1313
use function in_array;
14+
use function sprintf;
1415
use function strtolower;
1516

1617
/**
@@ -55,17 +56,13 @@ public function processNode(Node $node, Scope $scope): array
5556
&& ($leftType->isSuperTypeOf($rightType)->yes())
5657
&& ($rightType->isSuperTypeOf($leftType)->yes())
5758
) {
58-
if (strtolower($node->name->name) === 'assertnotequals') {
59-
return [
60-
RuleErrorBuilder::message(
61-
'You should use assertNotSame() instead of assertNotEquals(), because both values are scalars of the same type',
62-
)->identifier('phpunit.assertEquals')->build(),
63-
];
64-
}
65-
6659
return [
6760
RuleErrorBuilder::message(
68-
'You should use assertSame() instead of assertEquals(), because both values are scalars of the same type',
61+
sprintf(
62+
'You should use %s() instead of %s(), because both values are scalars of the same type',
63+
strtolower($node->name->name) === 'assertnotequals' ? 'assertNotSame' : 'assertSame',
64+
$node->name->name,
65+
),
6966
)->identifier('phpunit.assertEquals')->build(),
7067
];
7168
}

0 commit comments

Comments
 (0)