Do not invalidate types passed by value

Author: ondrejmirtes

src/Analyser/MutatingScope.php

@@ -3617,7 +3617,7 @@ private function shouldInvalidateExpression(string $exprStringToInvalidate, Expr
 		}
 
 		// Variables will not contain traversable expressions. skip the NodeFinder overhead
-		if ($expr instanceof Variable && is_string($expr->name)) {
+		if ($expr instanceof Variable && is_string($expr->name) && !$requireMoreCharacters) {
 			return $exprStringToInvalidate === $this->getNodeKey($expr);
 		}
 

src/Analyser/NodeScopeResolver.php

@@ -148,6 +148,7 @@
 use PHPStan\Type\NeverType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\ResourceType;
 use PHPStan\Type\StaticType;
 use PHPStan\Type\StaticTypeFactory;
 use PHPStan\Type\StringType;
@@ -2010,6 +2011,15 @@ static function (): void {
 					->invalidateExpression(new FuncCall(new Name\FullyQualified('json_last_error_msg'), []));
 			}
 
+			if (
+				$functionReflection !== null
+				&& $functionReflection->getName() === 'file_put_contents'
+				&& count($expr->getArgs()) > 0
+			) {
+				$scope = $scope->invalidateExpression(new FuncCall(new Name('file_get_contents'), [$expr->getArgs()[0]]))
+					->invalidateExpression(new FuncCall(new Name\FullyQualified('file_get_contents'), [$expr->getArgs()[0]]));
+			}
+
 			if (
 				$functionReflection !== null
 				&& in_array($functionReflection->getName(), ['array_pop', 'array_shift'], true)
@@ -3600,7 +3610,10 @@ private function processArgs(
 						$scope = $scope->invalidateExpression($argValue);
 					}
 				} elseif ($calleeReflection !== null && $calleeReflection->hasSideEffects()->yes()) {
-					$scope = $scope->invalidateExpression($arg->value, true);
+					$argType = $scope->getType($arg->value);
+					if (!$argType->isObject()->no() || !(new ResourceType())->isSuperTypeOf($argType)->no()) {
+						$scope = $scope->invalidateExpression($arg->value, true);
+					}
 				}
 			}
 

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -58,6 +58,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/strtotime-return-type-extensions.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/closure-return-type-extensions.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/array-key.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/discussion-9972.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/intersection-static.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/static-properties.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/static-methods.php');

tests/PHPStan/Analyser/data/discussion-9972.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Discussion9972;
+
+use PHPStan\TrinaryLogic;
+use function PHPStan\Testing\assertVariableCertainty;
+
+class HelloWorld
+{
+	public function f1(bool $myBool): void
+	{
+		if ($myBool) {
+			$myObject = new DateTime();
+		}
+
+		$this->helper($myBool);
+
+		if ($myBool) {
+			assertVariableCertainty(TrinaryLogic::createYes(), $myObject);
+		}
+	}
+
+	protected function helper(bool $input): void
+	{
+	}
+}