PHPStan Pro - present all errors with non-ignorable exceptions as internal errors

Author: ondrejmirtes

Diff for: src/Command/FixerWorkerCommand.php

@@ -210,6 +210,22 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 				$configuration,
 				$input,
 				function (array $errors, array $locallyIgnoredErrors, array $analysedFiles) use ($out, $ignoredErrorHelperResult, $isOnlyFiles, $inceptionFiles): void {
+					$internalErrors = [];
+					foreach ($errors as $fileSpecificError) {
+						if (!$fileSpecificError->hasNonIgnorableException()) {
+							continue;
+						}
+
+						$internalErrors[] = $this->transformErrorIntoInternalError($fileSpecificError);
+					}
+
+					if (count($internalErrors) > 0) {
+						$out->write(['action' => 'analysisCrash', 'data' => [
+							'internalErrors' => $internalErrors,
+						]]);
+						return;
+					}
+
 					[$errors, $ignoredErrors] = $this->filterErrors($errors, $ignoredErrorHelperResult, $isOnlyFiles, $inceptionFiles, false);
 					foreach ($locallyIgnoredErrors as $locallyIgnoredError) {
 						$ignoredErrors[] = [$locallyIgnoredError, null];
@@ -249,22 +265,7 @@ function (array $errors, array $locallyIgnoredErrors, array $analysedFiles) use
 						continue;
 					}
 
-					$message = $fileSpecificError->getMessage();
-					$metadata = $fileSpecificError->getMetadata();
-					if (
-						$fileSpecificError->getIdentifier() === 'phpstan.internal'
-						&& array_key_exists(InternalError::STACK_TRACE_AS_STRING_METADATA_KEY, $metadata)
-					) {
-						$message = sprintf('Internal error: %s', $message);
-					}
-
-					$internalErrors[] = new InternalError(
-						$message,
-						sprintf('analysing file %s', $fileSpecificError->getTraitFilePath() ?? $fileSpecificError->getFilePath()),
-						$metadata[InternalError::STACK_TRACE_METADATA_KEY] ?? [],
-						$metadata[InternalError::STACK_TRACE_AS_STRING_METADATA_KEY] ?? null,
-						true,
-					);
+					$internalErrors[] = $this->transformErrorIntoInternalError($fileSpecificError);
 				}
 
 				$hasInternalErrors = count($internalErrors) > 0 || $finalizerResult->getAnalyserResult()->hasReachedInternalErrorsCountLimit();
@@ -327,6 +328,26 @@ function (array $errors, array $locallyIgnoredErrors, array $analysedFiles) use
 		return 0;
 	}
 
+	private function transformErrorIntoInternalError(Error $error): InternalError
+	{
+		$message = $error->getMessage();
+		$metadata = $error->getMetadata();
+		if (
+			$error->getIdentifier() === 'phpstan.internal'
+			&& array_key_exists(InternalError::STACK_TRACE_AS_STRING_METADATA_KEY, $metadata)
+		) {
+			$message = sprintf('Internal error: %s', $message);
+		}
+
+		return new InternalError(
+			$message,
+			sprintf('analysing file %s', $error->getTraitFilePath() ?? $error->getFilePath()),
+			$metadata[InternalError::STACK_TRACE_METADATA_KEY] ?? [],
+			$metadata[InternalError::STACK_TRACE_AS_STRING_METADATA_KEY] ?? null,
+			true,
+		);
+	}
+
 	/**
 	 * @param string[] $inceptionFiles
 	 * @param array<Error> $errors