[BE] ArrayUnpackingRule

Author: ondrejmirtes

changelog-2.0.md

@@ -17,6 +17,7 @@ Major new features 🚀
 * Check that each trait is used and analysed at least once (level 4) (https://github.com/phpstan/phpstan-src/commit/c4d05276fb8605d6ac20acbe1cc5df31cd6c10b0)
 * Check preg_quote delimiter sanity (level 0) ([#3252](https://github.com/phpstan/phpstan-src/pull/3252)), #11338, thanks @staabm!
 * Rule for `call_user_func()` (level 5) ([#2479](https://github.com/phpstan/phpstan-src/pull/2479)), thanks @staabm!
+* ArrayUnpackingRule (level 3) ([#856](https://github.com/phpstan/phpstan-src/pull/856)), thanks @canvural!
 * Added previously absent type checks (level 0)
   * Check existing classes in `@phpstan-self-out` (https://github.com/phpstan/phpstan-src/commit/6838669976bf20232abde36ecdd52b1770fa50c9)
   * Check nonexistent classes in local type aliases (https://github.com/phpstan/phpstan-src/commit/2485b2e9c129e789ec3b2d7db81ca30f87c63911)
@@ -47,7 +48,6 @@ Bleeding edge (TODO move to other sections)
 
 * Report useless `array_filter()` calls ([#1077](https://github.com/phpstan/phpstan-src/pull/1077)), #6840, thanks @leongersen!
 * Specify explicit mixed array type via `is_array` ([#1191](https://github.com/phpstan/phpstan-src/pull/1191)), thanks @herndlm!
-* ArrayUnpackingRule (level 3) ([#856](https://github.com/phpstan/phpstan-src/pull/856)), thanks @canvural!
 * Rules for checking direct calls to `__construct()` (level 2) ([#1208](https://github.com/phpstan/phpstan-src/pull/1208)), #7022, thanks @muno92!
 * ConstantLooseComparisonRule - level 4 (https://github.com/phpstan/phpstan-src/commit/6ebf2361a3c831dd105a815521889428c295dc9f)
 * Unresolvable parameters ([#1319](https://github.com/phpstan/phpstan-src/pull/1319)), thanks @rvanvelzen!

conf/bleedingEdge.neon

@@ -6,7 +6,6 @@ parameters:
 
 		explicitMixedViaIsArray: true
 		arrayFilter: true
-		arrayUnpacking: true
 		arrayValues: true
 		strictUnnecessaryNullsafePropertyFetch: true
 		looseComparison: true

conf/config.level3.neon

@@ -2,15 +2,14 @@ includes:
 	- config.level2.neon
 
 conditionalTags:
-	PHPStan\Rules\Arrays\ArrayUnpackingRule:
-		phpstan.rules.rule: %featureToggles.arrayUnpacking%
 	PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyAssignRefRule:
 		phpstan.rules.rule: %featureToggles.readOnlyByPhpDoc%
 	PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyAssignRule:
 		phpstan.rules.rule: %featureToggles.readOnlyByPhpDoc%
 
 rules:
 	- PHPStan\Rules\Arrays\ArrayDestructuringRule
+	- PHPStan\Rules\Arrays\ArrayUnpackingRule
 	- PHPStan\Rules\Arrays\IterableInForeachRule
 	- PHPStan\Rules\Arrays\OffsetAccessAssignmentRule
 	- PHPStan\Rules\Arrays\OffsetAccessAssignOpRule
@@ -85,9 +84,6 @@ services:
 		tags:
 			- phpstan.rules.rule
 
-	-
-		class: PHPStan\Rules\Arrays\ArrayUnpackingRule
-
 	-
 		class: PHPStan\Rules\Properties\ReadOnlyByPhpDocPropertyAssignRefRule
 

conf/config.neon

@@ -26,7 +26,6 @@ parameters:
 		skipCheckGenericClasses: []
 		explicitMixedViaIsArray: false
 		arrayFilter: false
-		arrayUnpacking: false
 		arrayValues: false
 		illegalConstructorMethodCall: false
 		strictUnnecessaryNullsafePropertyFetch: false

conf/parametersSchema.neon

@@ -32,7 +32,6 @@ parametersSchema:
 		skipCheckGenericClasses: listOf(string()),
 		explicitMixedViaIsArray: bool(),
 		arrayFilter: bool(),
-		arrayUnpacking: bool(),
 		arrayValues: bool(),
 		illegalConstructorMethodCall: bool(),
 		strictUnnecessaryNullsafePropertyFetch: bool(),