Fix narrowing of superglobals

Author: herndlm

Diff for: src/Analyser/MutatingScope.php

@@ -554,10 +554,13 @@ public function getVariableType(string $variableName): Type
 
 		$varExprString = '$' . $variableName;
 		if (!array_key_exists($varExprString, $this->expressionTypes)) {
-			if ($this->isGlobalVariable($variableName)) {
-				return new ArrayType(new BenevolentUnionType([new IntegerType(), new StringType()]), new MixedType(true));
+			if (!$this->isGlobalVariable($variableName)) {
+				return new MixedType();
 			}
-			return new MixedType();
+
+			$superglobalType = new ArrayType(new BenevolentUnionType([new IntegerType(), new StringType()]), new MixedType(true));
+			$this->expressionTypes[$varExprString] = ExpressionTypeHolder::createYes(new Variable($variableName), $superglobalType);
+			$this->nativeExpressionTypes[$varExprString] = ExpressionTypeHolder::createYes(new Variable($variableName), $superglobalType);
 		}
 
 		return TypeUtils::resolveLateResolvableTypes($this->expressionTypes[$varExprString]->getType());

Diff for: tests/PHPStan/Analyser/nsrt/superglobals.php

@@ -0,0 +1,59 @@
+<?php declare(strict_types=1);
+
+namespace Superglobals;
+
+use function PHPStan\Testing\assertNativeType;
+use function PHPStan\Testing\assertType;
+
+class Superglobals
+{
+
+	public function originalTypes(): void
+	{
+		assertType('array<mixed>', $GLOBALS);
+		assertType('array<mixed>', $_SERVER);
+		assertType('array<mixed>', $_GET);
+		assertType('array<mixed>', $_POST);
+		assertType('array<mixed>', $_FILES);
+		assertType('array<mixed>', $_COOKIE);
+		assertType('array<mixed>', $_SESSION);
+		assertType('array<mixed>', $_REQUEST);
+		assertType('array<mixed>', $_ENV);
+	}
+
+	public function canBeOverwritten(): void
+	{
+		$GLOBALS = [];
+		assertType('array{}', $GLOBALS);
+		assertNativeType('array{}', $GLOBALS);
+	}
+
+	public function canBePartlyOverwritten(): void
+	{
+		$GLOBALS['foo'] = 'foo';
+		assertType("non-empty-array&hasOffsetValue('foo', 'foo')", $GLOBALS);
+		assertNativeType("non-empty-array&hasOffsetValue('foo', 'foo')", $GLOBALS);
+	}
+
+	public function canBeNarrowed(): void
+	{
+		if (isset($GLOBALS['foo'])) {
+			assertType("non-empty-array&hasOffsetValue('foo', mixed~null)", $GLOBALS);
+			assertNativeType("non-empty-array<mixed>&hasOffset('foo')", $GLOBALS); // https://github.com/phpstan/phpstan/issues/8395
+		} else {
+			assertType('array<mixed>', $GLOBALS);
+			assertNativeType('array<mixed>', $GLOBALS);
+		}
+		assertType('array', $GLOBALS);
+		assertNativeType('array<mixed>', $GLOBALS);
+	}
+
+}
+
+function functionScope() {
+	assertType('array<mixed>', $GLOBALS);
+	assertNativeType('array<mixed>', $GLOBALS);
+}
+
+assertType('array<mixed>', $GLOBALS);
+assertNativeType('array<mixed>', $GLOBALS);

Diff for: tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -1001,4 +1001,9 @@ public function testHashing(): void
 		]);
 	}
 
+	public function testBug12772(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-12772.php'], []);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Comparison/data/bug-12772.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12772;
+
+class HelloWorld
+{
+	public function sayHello(DateTimeImutable $date): void
+	{
+		foreach ($tables as $table) {
+
+			// If view exists, and 'add drop view' is selected: Drop it!
+			if ($_POST['what'] !== 'nocopy' && isset($_POST['drop_if_exists']) && $_POST['drop_if_exists'] === 'true') {
+
+			}
+		}
+	}
+}

Diff for: tests/PHPStan/Rules/Variables/IssetRuleTest.php

@@ -473,4 +473,11 @@ public function testBug9328(): void
 		$this->analyse([__DIR__ . '/data/bug-9328.php'], []);
 	}
 
+	public function testBug12771(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+
+		$this->analyse([__DIR__ . '/data/bug-12771.php'], []);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Variables/data/bug-12771.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types=1);
+
+namespace Bug12771;
+
+final class ErrorReportController
+{
+
+	public function __invoke(ServerRequest $request)
+	{
+		if (
+			isset($_SESSION['prev_error_subm_time'], $_SESSION['error_subm_count'])
+			&& $_SESSION['error_subm_count'] >= 3
+			&& ($_SESSION['prev_error_subm_time'] - time()) <= 3000
+		) {
+			$_SESSION['error_subm_count'] = 0;
+			$_SESSION['prev_errors'] = '';
+		} else {
+			$_SESSION['prev_error_subm_time'] = time();
+			$_SESSION['error_subm_count'] = isset($_SESSION['error_subm_count'])
+				? $_SESSION['error_subm_count'] + 1
+				: 0;
+		}
+
+	}
+}