Added support for ConstantString unions in RequireExtendsRule

Author: zonuexe

src/Rules/Classes/RequireExtendsRule.php

@@ -8,7 +8,6 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\VerbosityLevel;
-use function count;
 use function sprintf;
 
 /**
@@ -35,46 +34,49 @@ public function processNode(Node $node, Scope $scope): array
 			$extendsTags = $interface->getRequireExtendsTags();
 			foreach ($extendsTags as $extendsTag) {
 				$type = $extendsTag->getType();
-				$classNames = $type->getObjectClassNames();
-				if (count($classNames) === 1 && $classReflection->is($classNames[0])) {
-					continue;
-				}
+				foreach ($type->getObjectClassNames() as $className) {
+					if ($classReflection->is($className)) {
+						continue;
+					}
+
+					$errors[] = RuleErrorBuilder::message(
+						sprintf(
+							'Interface %s requires implementing class to extend %s, but %s does not.',
+							$interface->getDisplayName(),
+							$type->describe(VerbosityLevel::typeOnly()),
+							$classReflection->getDisplayName(),
+						),
+					)
+						->identifier('class.missingExtends')
+						->build();
 
-				$errors[] = RuleErrorBuilder::message(
-					sprintf(
-						'Interface %s requires implementing class to extend %s, but %s does not.',
-						$interface->getDisplayName(),
-						$type->describe(VerbosityLevel::typeOnly()),
-						$classReflection->getDisplayName(),
-					),
-				)
-					->identifier('class.missingExtends')
-					->build();
+					break;
+				}
 			}
 		}
 
 		foreach ($classReflection->getTraits(true) as $trait) {
 			$extendsTags = $trait->getRequireExtendsTags();
 			foreach ($extendsTags as $extendsTag) {
 				$type = $extendsTag->getType();
-				$classNames = $type->getObjectClassNames();
-				if (count($classNames) === 0) {
-					continue;
-				}
-				if (count($classNames) === 1 && $classReflection->is($classNames[0])) {
-					continue;
-				}
+				foreach ($type->getObjectClassNames() as $className) {
+					if ($classReflection->is($className)) {
+						continue;
+					}
+
+					$errors[] = RuleErrorBuilder::message(
+						sprintf(
+							'Trait %s requires using class to extend %s, but %s does not.',
+							$trait->getDisplayName(),
+							$type->describe(VerbosityLevel::typeOnly()),
+							$classReflection->getDisplayName(),
+						),
+					)
+						->identifier('class.missingExtends')
+						->build();
 
-				$errors[] = RuleErrorBuilder::message(
-					sprintf(
-						'Trait %s requires using class to extend %s, but %s does not.',
-						$trait->getDisplayName(),
-						$type->describe(VerbosityLevel::typeOnly()),
-						$classReflection->getDisplayName(),
-					),
-				)
-					->identifier('class.missingExtends')
-					->build();
+					break;
+				}
 			}
 		}
 

tests/PHPStan/Rules/Classes/RequireExtendsRuleTest.php

@@ -52,6 +52,22 @@ public function testRule(): void
 				'Trait IncompatibleRequireExtends\ValidPsalmTrait requires using class to extend IncompatibleRequireExtends\SomeClass, but class@anonymous/tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php:163 does not.',
 				163,
 			],
+			[
+				'Interface IncompatibleRequireExtends\RequireNonExisstentUnionClassinterface requires implementing class to extend IncompatibleRequireExtends\NonExistentClass|IncompatibleRequireExtends\SomeClass, but IncompatibleRequireExtends\RequireNonExisstentUnionClassinterface@anonymous/tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php:185 does not.',
+				185,
+			],
+			[
+				'Interface IncompatibleRequireExtends\RequireNonExisstentUnionClassinterface requires implementing class to extend IncompatibleRequireExtends\NonExistentClass|IncompatibleRequireExtends\SomeClass, but IncompatibleRequireExtends\SomeClass@anonymous/tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php:187 does not.',
+				187,
+			],
+			[
+				'Trait IncompatibleRequireExtends\RequireNonExisstentUnionClassTrait requires using class to extend IncompatibleRequireExtends\NonExistentClass|IncompatibleRequireExtends\SomeClass, but class@anonymous/tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php:194 does not.',
+				194,
+			],
+			[
+				'Trait IncompatibleRequireExtends\RequireNonExisstentUnionClassTrait requires using class to extend IncompatibleRequireExtends\NonExistentClass|IncompatibleRequireExtends\SomeClass, but IncompatibleRequireExtends\SomeClass@anonymous/tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php:198 does not.',
+				198,
+			],
 		];
 
 		$this->analyse([__DIR__ . '/../PhpDoc/data/incompatible-require-extends.php'], $expectedErrors);

tests/PHPStan/Rules/PhpDoc/data/incompatible-require-extends.php

@@ -176,3 +176,25 @@ trait TooMuchExtends {}
  * @phpstan-require-extends SomeOtherClass
  */
 interface TooMuchExtendsIface {}
+
+/**
+ * @phpstan-require-extends SomeClass|NonExistentClass
+ */
+interface RequireNonExisstentUnionClassinterface {}
+
+new class implements RequireNonExisstentUnionClassinterface {};
+
+new class extends SomeClass implements RequireNonExisstentUnionClassinterface {};
+
+/**
+ * @phpstan-require-extends SomeClass|NonExistentClass
+ */
+trait RequireNonExisstentUnionClassTrait {}
+
+new class {
+	use RequireNonExisstentUnionClassTrait;
+};
+
+new class extends SomeClass {
+	use RequireNonExisstentUnionClassTrait;
+};