Skip to content

Commit bb19be5

Browse files
staabmondrejmirtes
authored andcommitted
Remove $isFinal dead-code in PhpFunctionReflection
1 parent f11d56e commit bb19be5

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

src/Reflection/BetterReflection/BetterReflectionProvider.php

-3
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
304304
$deprecatedTag = null;
305305
$isDeprecated = false;
306306
$isInternal = false;
307-
$isFinal = false;
308307
$isPure = null;
309308
$asserts = Assertions::createEmpty();
310309
$acceptsNamedArguments = true;
@@ -327,7 +326,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
327326
$deprecatedTag = $resolvedPhpDoc->getDeprecatedTag();
328327
$isDeprecated = $resolvedPhpDoc->isDeprecated();
329328
$isInternal = $resolvedPhpDoc->isInternal();
330-
$isFinal = $resolvedPhpDoc->isFinal();
331329
$isPure = $resolvedPhpDoc->isPure();
332330
$asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
333331
if ($resolvedPhpDoc->hasPhpDocString()) {
@@ -348,7 +346,6 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
348346
$deprecatedTag !== null ? $deprecatedTag->getMessage() : null,
349347
$isDeprecated,
350348
$isInternal,
351-
$isFinal,
352349
$reflectionFunction->getFileName() !== false ? $reflectionFunction->getFileName() : null,
353350
$isPure,
354351
$asserts,

src/Reflection/FunctionReflectionFactory.php

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public function create(
2525
?string $deprecatedDescription,
2626
bool $isDeprecated,
2727
bool $isInternal,
28-
bool $isFinal,
2928
?string $filename,
3029
?bool $isPure,
3130
Assertions $asserts,

src/Reflection/Php/PhpFunctionReflection.php

-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public function __construct(
5454
private ?string $deprecatedDescription,
5555
private bool $isDeprecated,
5656
private bool $isInternal,
57-
private bool $isFinal,
5857
private ?string $filename,
5958
private ?bool $isPure,
6059
private Assertions $asserts,

0 commit comments

Comments
 (0)