test functions

Author: staabm

src/Parser/VariadicMethodsVisitor.php

@@ -6,10 +6,11 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeVisitorAbstract;
-use PHPStan\Node\AnonymousClassNode;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\TrinaryLogic;
 use function array_key_exists;
+use function array_pop;
+use function implode;
 use function in_array;
 
 final class VariadicMethodsVisitor extends NodeVisitorAbstract
@@ -21,9 +22,7 @@ final class VariadicMethodsVisitor extends NodeVisitorAbstract
 
 	private ?string $inClassLike = null;
 
-	/**
-	 * @var array<string>
-	 */
+	/** @var array<string> */
 	private array $classStack = [];
 
 	private ?string $inMethod = null;
@@ -60,7 +59,7 @@ public function enterNode(Node $node): ?Node
 			|| $node instanceof Node\Stmt\ClassLike
 		) {
 			if (!$node->name instanceof Node\Identifier) {
-				$className = 'class@anonymous';
+				$className = 'class@anonymous:' . $node->getStartLine();
 			} else {
 				$className = $node->name->name;
 			}

tests/PHPStan/Parser/ParserTest.php

@@ -21,6 +21,7 @@ public function dataVariadicCallLikes(): iterable
 				'VariadicFunctions\variadic_fn1' => TrinaryLogic::createYes(),
 				'VariadicFunctions\nonvariadic' => TrinaryLogic::createNo(),
 				'VariadicFunctions\maybe_variadic_fn1' => TrinaryLogic::createNo(),
+				'VariadicFunctions\implicit_variadic_fn1' => TrinaryLogic::createYes(),
 			],
 		];
 
@@ -38,12 +39,12 @@ public function dataVariadicCallLikes(): iterable
 					'variadic_fnZ' => TrinaryLogic::createNo(), // variadicness later on detected via reflection
 					'implicit_variadic_fnZ' => TrinaryLogic::createYes(),
 				],
-				'VariadicMethod\Z\class@anonymous' => [
+				'VariadicMethod\Z\class@anonymous:20' => [
 					'non_variadic_fn_subZ' => TrinaryLogic::createNo(),
 					'variadic_fn_subZ' => TrinaryLogic::createNo(), // variadicness later on detected via reflection
 					'implicit_variadic_subZ' => TrinaryLogic::createYes(),
 				],
-				'VariadicMethod\class@anonymous' => [
+				'VariadicMethod\class@anonymous:42' => [
 					'non_variadic_fn' => TrinaryLogic::createNo(),
 					'variadic_fn' => TrinaryLogic::createNo(), // variadicness later on detected via reflection
 					'implicit_variadic_fn' => TrinaryLogic::createYes(),
@@ -60,7 +61,7 @@ public function dataVariadicCallLikes(): iterable
 					'variadic_fn1' => TrinaryLogic::createNo(), // variadicness later on detected via reflection
 					'implicit_variadic_fn1' => TrinaryLogic::createYes(),
 				],
-			]
+			],
 		];
 	}
 

tests/PHPStan/Parser/data/variadic-functions.php

@@ -25,3 +25,7 @@ function maybe_variadic_fn1(...$v)
 $fn2 = function ($x) use ($y) {
 	return $x + $y;
 };
+
+function implicit_variadic_fn1() {
+	$args = func_get_args();
+}