Add tests

Author: zonuexe

Diff for: tests/PHPStan/Rules/Classes/ClassConstantRuleTest.php

@@ -435,4 +435,24 @@ public function testClassConstantAccessedOnTrait(): void
 		]);
 	}
 
+	public function testDynamicAccess(): void
+	{
+		if (PHP_VERSION_ID < 80200) {
+			$this->markTestSkipped('Test requires PHP 8.2.');
+		}
+
+		$this->phpVersion = PHP_VERSION_ID;
+
+		$this->analyse([__DIR__ . '/data/dynamic-constant-access.php'], [
+			[
+				'Access to undefined constant ClassConstantDynamicAccess\Foo::FOO.',
+				20,
+			],
+			[
+				'Access to undefined constant ClassConstantDynamicAccess\Foo::BUZ.',
+				20,
+			],
+		]);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Classes/data/dynamic-constant-access.php

@@ -0,0 +1,23 @@
+<?php  // lint >= 8.2
+
+namespace ClassConstantDynamicAccess;
+
+final class Foo
+{
+
+	private const BAR = 'FOO';
+
+	/** @var 'FOO'|'BAR'|'BUZ' */
+	public $name;
+
+	public function test(string $string, object $obj): void
+	{
+		$bar = 'FOO';
+
+		echo self::{$foo};
+		echo self::{$string};
+		echo self::{$obj};
+		echo self::{$this->name};
+	}
+
+}

Diff for: tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3552,4 +3552,27 @@ public function testBug6828(): void
 		$this->analyse([__DIR__ . '/data/bug-6828.php'], []);
 	}
 
+	public function testDynamicCall(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->checkExplicitMixed = true;
+
+		$this->analyse([__DIR__ . '/data/dynamic-call.php'], [
+			[
+				'Call to an undefined method MethodsDynamicCall\Foo::bar().',
+				23,
+			],
+			[
+				'Call to an undefined method MethodsDynamicCall\Foo::bar().',
+				26,
+			],
+			[
+				'Call to an undefined method MethodsDynamicCall\Foo::buz().',
+				26,
+			],
+		]);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -862,4 +862,26 @@ public function testBug12015(): void
 		$this->analyse([__DIR__ . '/data/bug-12015.php'], []);
 	}
 
+	public function testDynamicCall(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+
+		$this->analyse([__DIR__ . '/data/dynamic-call.php'], [
+			[
+				'Call to an undefined static method MethodsDynamicCall\Foo::bar().',
+				33,
+			],
+			[
+				'Call to an undefined static method MethodsDynamicCall\Foo::bar().',
+				36,
+			],
+			[
+				'Call to an undefined static method MethodsDynamicCall\Foo::buz().',
+				36,
+			],
+		]);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Methods/data/dynamic-call.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace MethodsDynamicCall;
+
+final class Foo
+{
+
+	/** @var 'foo'|'bar'|'buz'|'qux' */
+	public static $name;
+
+	public function foo(): void
+	{
+	}
+
+	public static function qux(): void
+	{
+	}
+
+	public function test(string $string, object $obj): void
+	{
+		$foo = 'bar';
+
+		echo $this->$foo();
+		echo $this->$string();
+		echo $this->$obj();
+		echo $this->{self::$name}();
+	}
+
+	public function testStaticCall(string $string, object $obj): void
+	{
+		$foo = 'bar';
+
+		echo self::$foo();
+		echo self::$string();
+		echo self::$obj();
+		echo self::{self::$name}();
+	}
+}

Diff for: tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -1098,4 +1098,26 @@ public function testPropertyHooks(): void
 		]);
 	}
 
+	public function testDynamicAccess(): void
+	{
+		$this->cliArgumentsVariablesRegistered = true;
+		$this->polluteScopeWithLoopInitialAssignments = true;
+		$this->checkMaybeUndefinedVariables = true;
+		$this->polluteScopeWithAlwaysIterableForeach = true;
+		$this->analyse([__DIR__ . '/data/dynamic-access.php'], [
+			[
+				'Undefined variable: $bar',
+				15,
+			],
+			[
+				'Undefined variable: $bar',
+				18,
+			],
+			[
+				'Undefined variable: $buz',
+				18,
+			],
+		]);
+	}
+
 }

Diff for: tests/PHPStan/Rules/Variables/data/dynamic-access.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace VariablesDynamicAccess;
+
+final class Foo
+{
+
+	/** @var 'foo'|'bar'|'buz' */
+	public $name;
+
+	public function test(string $string, object $obj): void
+	{
+		$foo = 'bar';
+
+		echo $$foo;
+		echo $$string;
+		echo $$obj;
+		echo ${$this->name};
+	}
+
+}