getOption() can return int

Author: lookyman

Diff for: src/Rules/Symfony/InvalidOptionDefaultValueRule.php

@@ -66,7 +66,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		// not an array
 		if (($mode & 8) !== 8) {
-			$checkType = new UnionType([new StringType(), new NullType()]);
+			$checkType = new UnionType([new StringType(), new IntegerType(), new NullType()]);
 			if (($mode & 4) === 4) { // https://symfony.com/doc/current/console/input.html#options-with-optional-arguments
 				$checkType = TypeCombinator::union($checkType, new ConstantBooleanType(false));
 			}

Diff for: src/Type/Symfony/InputInterfaceGetOptionDynamicReturnTypeExtension.php

@@ -67,12 +67,12 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 				if (!$option->acceptValue()) {
 					$optType = new BooleanType();
 				} else {
-					$optType = TypeCombinator::union(new StringType(), new NullType());
+					$optType = TypeCombinator::union(new StringType(), new IntegerType(), new NullType());
 					if ($option->isValueRequired() && ($option->isArray() || $option->getDefault() !== null)) {
 						$optType = TypeCombinator::removeNull($optType);
 					}
 					if ($option->isArray()) {
-						$optType = new ArrayType(new IntegerType(), $optType);
+						$optType = new ArrayType(new IntegerType(), TypeCombinator::remove($optType, new IntegerType()));
 					}
 					$optType = TypeCombinator::union($optType, $scope->getTypeFromValue($option->getDefault()));
 				}

Diff for: tests/Rules/Symfony/InvalidOptionDefaultValueRuleTest.php

@@ -24,10 +24,6 @@ public function testGetArgument(): void
 					'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<int, string>|null, array<int, int> given.',
 					29,
 				],
-				[
-					'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects string|false|null, int given.',
-					30,
-				],
 			]
 		);
 	}

Diff for: tests/Type/Symfony/InputInterfaceGetOptionDynamicReturnTypeExtensionTest.php

@@ -24,8 +24,8 @@ public function testArgumentTypes(string $expression, string $type): void
 	public function argumentTypesProvider(): Iterator
 	{
 		yield ['$a', 'bool'];
-		yield ['$b', 'string|null'];
-		yield ['$c', 'string|null'];
+		yield ['$b', 'int|string|null'];
+		yield ['$c', 'int|string|null'];
 		yield ['$d', 'array<int, string|null>'];
 		yield ['$e', 'array<int, string>'];