From ce3c25807d9713897605b420c6830d6a86cf56b5 Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Thu, 8 Jun 2023 11:07:26 +0200
Subject: [PATCH] Error identifiers

---
 src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php | 1 +
 src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php | 4 +++-
 src/Rules/Symfony/InvalidArgumentDefaultValueRule.php      | 4 ++--
 src/Rules/Symfony/InvalidOptionDefaultValueRule.php        | 4 ++--
 src/Rules/Symfony/UndefinedArgumentRule.php                | 4 +++-
 src/Rules/Symfony/UndefinedOptionRule.php                  | 4 +++-
 6 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php b/src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php
index 5e10c2b8..996d3b77 100644
--- a/src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php
+++ b/src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php
@@ -71,6 +71,7 @@ public function processNode(Node $node, Scope $scope): array
 			if ($service !== null && !$service->isPublic()) {
 				return [
 					RuleErrorBuilder::message(sprintf('Service "%s" is private.', $serviceId))
+						->identifier('symfonyContainer.privateService')
 						->build(),
 				];
 			}
diff --git a/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php b/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php
index ccc1999e..fc7d9585 100644
--- a/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php
+++ b/src/Rules/Symfony/ContainerInterfaceUnknownServiceRule.php
@@ -71,7 +71,9 @@ public function processNode(Node $node, Scope $scope): array
 			$serviceIdType = $scope->getType($node->getArgs()[0]->value);
 			if ($service === null && !$scope->getType(Helper::createMarkerNode($node->var, $serviceIdType, $this->printer))->equals($serviceIdType)) {
 				return [
-					RuleErrorBuilder::message(sprintf('Service "%s" is not registered in the container.', $serviceId))->build(),
+					RuleErrorBuilder::message(sprintf('Service "%s" is not registered in the container.', $serviceId))
+						->identifier('symfonyContainer.serviceNotFound')
+						->build(),
 				];
 			}
 		}
diff --git a/src/Rules/Symfony/InvalidArgumentDefaultValueRule.php b/src/Rules/Symfony/InvalidArgumentDefaultValueRule.php
index a55881ce..153d4af5 100644
--- a/src/Rules/Symfony/InvalidArgumentDefaultValueRule.php
+++ b/src/Rules/Symfony/InvalidArgumentDefaultValueRule.php
@@ -63,7 +63,7 @@ public function processNode(Node $node, Scope $scope): array
 				RuleErrorBuilder::message(sprintf(
 					'Parameter #4 $default of method Symfony\Component\Console\Command\Command::addArgument() expects string|null, %s given.',
 					$defaultType->describe(VerbosityLevel::typeOnly())
-				))->build(),
+				))->identifier('argument.type')->build(),
 			];
 		}
 
@@ -73,7 +73,7 @@ public function processNode(Node $node, Scope $scope): array
 				RuleErrorBuilder::message(sprintf(
 					'Parameter #4 $default of method Symfony\Component\Console\Command\Command::addArgument() expects array<int, string>|null, %s given.',
 					$defaultType->describe(VerbosityLevel::typeOnly())
-				))->build(),
+				))->identifier('argument.type')->build(),
 			];
 		}
 
diff --git a/src/Rules/Symfony/InvalidOptionDefaultValueRule.php b/src/Rules/Symfony/InvalidOptionDefaultValueRule.php
index 6964d25e..1595f4a8 100644
--- a/src/Rules/Symfony/InvalidOptionDefaultValueRule.php
+++ b/src/Rules/Symfony/InvalidOptionDefaultValueRule.php
@@ -68,7 +68,7 @@ public function processNode(Node $node, Scope $scope): array
 						'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects %s, %s given.',
 						$checkType->describe(VerbosityLevel::typeOnly()),
 						$defaultType->describe(VerbosityLevel::typeOnly())
-					))->build(),
+					))->identifier('argument.type')->build(),
 				];
 			}
 		}
@@ -79,7 +79,7 @@ public function processNode(Node $node, Scope $scope): array
 				RuleErrorBuilder::message(sprintf(
 					'Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects array<string>|null, %s given.',
 					$defaultType->describe(VerbosityLevel::typeOnly())
-				))->build(),
+				))->identifier('argument.type')->build(),
 			];
 		}
 
diff --git a/src/Rules/Symfony/UndefinedArgumentRule.php b/src/Rules/Symfony/UndefinedArgumentRule.php
index 07f35e2a..cd8be894 100644
--- a/src/Rules/Symfony/UndefinedArgumentRule.php
+++ b/src/Rules/Symfony/UndefinedArgumentRule.php
@@ -75,7 +75,9 @@ public function processNode(Node $node, Scope $scope): array
 				if ($scope->getType(Helper::createMarkerNode($node->var, $argType, $this->printer))->equals($argType)) {
 					continue;
 				}
-				$errors[] = RuleErrorBuilder::message(sprintf('Command "%s" does not define argument "%s".', $name, $argName))->build();
+				$errors[] = RuleErrorBuilder::message(sprintf('Command "%s" does not define argument "%s".', $name, $argName))
+					->identifier('symfonyConsole.argumentNotFound')
+					->build();
 			}
 		}
 
diff --git a/src/Rules/Symfony/UndefinedOptionRule.php b/src/Rules/Symfony/UndefinedOptionRule.php
index 5a8dc8e3..095bd44d 100644
--- a/src/Rules/Symfony/UndefinedOptionRule.php
+++ b/src/Rules/Symfony/UndefinedOptionRule.php
@@ -75,7 +75,9 @@ public function processNode(Node $node, Scope $scope): array
 				if ($scope->getType(Helper::createMarkerNode($node->var, $optType, $this->printer))->equals($optType)) {
 					continue;
 				}
-				$errors[] = RuleErrorBuilder::message(sprintf('Command "%s" does not define option "%s".', $name, $optName))->build();
+				$errors[] = RuleErrorBuilder::message(sprintf('Command "%s" does not define option "%s".', $name, $optName))
+					->identifier('symfonyConsole.optionNotFound')
+					->build();
 			}
 		}