Initial implementation of SymfonyContainerResultCacheMetaExtension

Author: Wirone

Diff for: composer.json

@@ -15,7 +15,7 @@
   "require": {
     "php": "^7.4 || ^8.0",
     "ext-simplexml": "*",
-    "phpstan/phpstan": "^2.0"
+    "phpstan/phpstan": "^2.1.2"
   },
   "conflict": {
     "symfony/framework-bundle": "<3.0"

Diff for: extension.neon

@@ -363,3 +363,8 @@ services:
 	-
 		factory: PHPStan\Type\Symfony\ExtensionGetConfigurationReturnTypeExtension
 		tags: [phpstan.broker.dynamicMethodReturnTypeExtension]
+
+	-
+		class: PHPStan\Symfony\SymfonyContainerResultCacheMetaExtension
+		tags:
+			- phpstan.resultCacheMetaExtension

Diff for: src/Symfony/SymfonyContainerResultCacheMetaExtension.php

@@ -0,0 +1,54 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Symfony;
+
+use PHPStan\Analyser\ResultCache\ResultCacheMetaExtension;
+use function array_map;
+use function hash;
+use function serialize;
+
+final class SymfonyContainerResultCacheMetaExtension implements ResultCacheMetaExtension
+{
+
+	private ParameterMapFactory $parameterMapFactory;
+
+	private ServiceMapFactory $serviceMapFactory;
+
+	public function __construct(
+		ParameterMapFactory $parameterMapFactory,
+		ServiceMapFactory $serviceMapFactory
+	)
+	{
+		$this->parameterMapFactory = $parameterMapFactory;
+		$this->serviceMapFactory = $serviceMapFactory;
+	}
+
+	public function getKey(): string
+	{
+		return 'symfonyDiContainer';
+	}
+
+	public function getHash(): string
+	{
+		return hash('sha256', serialize([
+			'parameters' => array_map(
+				static fn (ParameterDefinition $parameter) => [
+					'name' => $parameter->getKey(),
+					'value' => $parameter->getValue(),
+				],
+				$this->parameterMapFactory->create()->getParameters(),
+			),
+			'services' => array_map(
+				static fn (ServiceDefinition $service) => [
+					'id' => $service->getId(),
+					'class' => $service->getClass(),
+					'public' => $service->isPublic() ? 'yes' : 'no',
+					'synthetic' => $service->isSynthetic() ? 'yes' : 'no',
+					'alias' => $service->getAlias(),
+				],
+				$this->serviceMapFactory->create()->getServices(),
+			),
+		]));
+	}
+
+}

Diff for: src/Symfony/XmlParameterMapFactory.php

@@ -8,13 +8,16 @@
 use function base64_decode;
 use function file_get_contents;
 use function is_numeric;
+use function ksort;
 use function simplexml_load_string;
 use function sprintf;
 use function strpos;
 
 final class XmlParameterMapFactory implements ParameterMapFactory
 {
 
+	private ?ParameterMap $parameterMap = null;
+
 	private ?string $containerXml = null;
 
 	public function __construct(?string $containerXmlPath)
@@ -24,6 +27,10 @@ public function __construct(?string $containerXmlPath)
 
 	public function create(): ParameterMap
 	{
+		if ($this->parameterMap !== null) {
+			return $this->parameterMap;
+		}
+
 		if ($this->containerXml === null) {
 			return new FakeParameterMap();
 		}
@@ -52,7 +59,9 @@ public function create(): ParameterMap
 			$parameters[$parameter->getKey()] = $parameter;
 		}
 
-		return new DefaultParameterMap($parameters);
+		ksort($parameters);
+
+		return $this->parameterMap = new DefaultParameterMap($parameters);
 	}
 
 	/**

Diff for: src/Symfony/XmlServiceMapFactory.php

@@ -4,6 +4,7 @@
 
 use SimpleXMLElement;
 use function file_get_contents;
+use function ksort;
 use function simplexml_load_string;
 use function sprintf;
 use function strpos;
@@ -12,6 +13,8 @@
 final class XmlServiceMapFactory implements ServiceMapFactory
 {
 
+	private ?ServiceMap $serviceMap = null;
+
 	private ?string $containerXml = null;
 
 	public function __construct(?string $containerXmlPath)
@@ -21,6 +24,10 @@ public function __construct(?string $containerXmlPath)
 
 	public function create(): ServiceMap
 	{
+		if ($this->serviceMap !== null) {
+			return $this->serviceMap;
+		}
+
 		if ($this->containerXml === null) {
 			return new FakeServiceMap();
 		}
@@ -85,7 +92,9 @@ public function create(): ServiceMap
 			);
 		}
 
-		return new DefaultServiceMap($services);
+		ksort($services);
+
+		return $this->serviceMap = new DefaultServiceMap($services);
 	}
 
 	private function cleanServiceId(string $id): string