Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 3049be1

Browse files
committed
Cleanup stubs in ScriptCompiler namespace [skip ci]
1 parent a05c67a commit 3049be1

File tree

3 files changed

+26
-19
lines changed

3 files changed

+26
-19
lines changed

Diff for: stubs/src/ScriptCompiler/CachedData.php

+12-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11
<?php declare(strict_types=1);
22

3+
/**
4+
* This file is part of the pinepain/php-v8 PHP extension.
5+
*
6+
* Copyright (c) 2015-2017 Bogdan Padalko <[email protected]>
7+
*
8+
* Licensed under the MIT license: http://opensource.org/licenses/MIT
9+
*
10+
* For the full copyright and license information, please view the
11+
* LICENSE file that was distributed with this source or visit
12+
* http://opensource.org/licenses/MIT
13+
*/
14+
315

416
namespace V8\ScriptCompiler;
517

@@ -21,11 +33,6 @@ public function getData(): string
2133
{
2234
}
2335

24-
// TODO: technically, we can use \strlen($this->getData()) when we need, though in PHP it's not necessary to get string length before fetching string itself
25-
//public function getLength(): int
26-
//{
27-
//}
28-
2936
public function isRejected(): bool
3037
{
3138
}

Diff for: stubs/src/ScriptCompiler/CompileOptions.php

-14
This file was deleted.

Diff for: stubs/src/ScriptCompiler/Source.php

+14
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,21 @@
11
<?php declare(strict_types=1);
22

3+
/**
4+
* This file is part of the pinepain/php-v8 PHP extension.
5+
*
6+
* Copyright (c) 2015-2017 Bogdan Padalko <[email protected]>
7+
*
8+
* Licensed under the MIT license: http://opensource.org/licenses/MIT
9+
*
10+
* For the full copyright and license information, please view the
11+
* LICENSE file that was distributed with this source or visit
12+
* http://opensource.org/licenses/MIT
13+
*/
14+
15+
316
namespace V8\ScriptCompiler;
417

18+
519
use V8\ScriptOrigin;
620
use V8\StringValue;
721

0 commit comments

Comments
 (0)